Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve look of bar charts slightly #8875

Merged
merged 2 commits into from
Jan 31, 2025
Merged

Improve look of bar charts slightly #8875

merged 2 commits into from
Jan 31, 2025

Conversation

emilk
Copy link
Member

@emilk emilk commented Jan 30, 2025

What

Removes the gap between the bars. The gaps looked uneven because of pixel grid aliasing. Better to have no gaps (it is far less noticeable that some bars are a pixel wider/narrower than others since they are already so wide).

Before/after

The comparison pictures are taken on a high-DPI display. The difference is much bigger on a low-DPI display.

Before

Screenshot 2025-01-31 at 05 13 41

After

image

@emilk emilk added ui concerns graphical user interface include in changelog egui Requires egui/eframe work labels Jan 30, 2025
Copy link

github-actions bot commented Jan 30, 2025

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
f8aa768 https://rerun.io/viewer/pr/8875 +nightly +main

Note: This comment is updated whenever you push a commit.

@emilk emilk marked this pull request as ready for review January 31, 2025 04:16
Copy link
Member

@abey79 abey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it does look better.

@emilk emilk merged commit f4c1e27 into main Jan 31, 2025
37 of 38 checks passed
@emilk emilk deleted the emilk/improve-bar-charts branch January 31, 2025 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
egui Requires egui/eframe work include in changelog ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants