Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement range selection with shift-click in the time panel #8870

Merged
merged 3 commits into from
Jan 30, 2025
+383 −171
Merged

Implement range selection with shift-click in the time panel #8870

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
76d07db
Add support for shit-click range selection in the streams tree
abey79 Jan 30, 2025
8baa0de
lint
abey79 Jan 30, 2025
4b4ea81
review comments
abey79 Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6566,6 +6566,7 @@ dependencies = [
"re_log_types",
"re_tracing",
"re_types",
"re_types_core",
"re_ui",
"re_viewer_context",
"re_viewport_blueprint",
Expand Down
3 changes: 2 additions & 1 deletion crates/viewer/re_time_panel/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,11 @@ re_data_ui.workspace = true
re_entity_db.workspace = true
re_format.workspace = true
re_int_histogram.workspace = true
re_log_types.workspace = true
re_log.workspace = true
re_log_types.workspace = true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

somewhat curious this needs log types actually and not just types_core, ah well...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was there already, was just reordered.

use re_log_types::{
    ApplicationId, ComponentPath, EntityPath, ResolvedTimeRange, TimeInt, TimeReal, TimeType,
};

re_tracing.workspace = true
re_types.workspace = true
re_types_core.workspace = true
re_ui.workspace = true
re_viewer_context.workspace = true
re_viewport_blueprint.workspace = true
Expand Down
Loading
Loading