Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clickable URLs in named components / AnyValues #8864

Merged
merged 14 commits into from
Jan 30, 2025
Merged

Clickable URLs in named components / AnyValues #8864

merged 14 commits into from
Jan 30, 2025

Conversation

grtlr
Copy link
Contributor

@grtlr grtlr commented Jan 30, 2025 •
edited
Loading

Related

What

Title.

Screen.Recording.2025-01-30.at.14.43.54.mov

Minor problems before this can be merged

  • The component name disappears when hovering over the URI entry, and maybe related
  • The chunk store browser crashes with a panic.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 30, 2025 •
edited
Loading

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
✅ 39ad78b https://rerun.io/viewer/pr/8864 +nightly +main

Note: This comment is updated whenever you push a commit.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 30, 2025 •
edited
Loading

Latest documentation preview deployed successfully.

Result Commit Link
✅ 39ad78b https://landing-eyrlhraiz-rerun.vercel.app/docs

Note: This comment is updated whenever you push a commit.

@grtlr grtlr marked this pull request as ready for review January 30, 2025 13:48
@grtlr grtlr added enhancement New feature or request ui concerns graphical user interface include in changelog labels Jan 30, 2025
@abey79 abey79 self-requested a review January 30, 2025 14:04
abey79
abey79 approved these changes Jan 30, 2025
View reviewed changes
Copy link
Member

@abey79 abey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I was initially unhappy to see re_hyperlink not truncate in the narrow snapshot, but the last commit updated the snapshot :)

crates/viewer/re_ui/src/ui_layout.rs Show resolved Hide resolved
@grtlr grtlr merged commit 46225f7 into main Jan 30, 2025
32 checks passed
@grtlr grtlr deleted the grtlr/arrow-rendering-clickable-ui branch January 30, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abey79 abey79 abey79 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request include in changelog ui concerns graphical user interface
Projects
None yet
Milestone
0.22 - Entity filtering and partial u...
Development

Successfully merging this pull request may close these issues.

Detect URLs in strings and render them appropriately
2 participants
@grtlr @abey79