Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clickable URI component #8567

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Add clickable URI component #8567

wants to merge 12 commits into from

Conversation

grtlr
Copy link
Contributor

@grtlr grtlr commented Jan 2, 2025

The component can be clicked in the tooltip and in the selection panel.

image image

The component can be clicked in the tooltip and in the selection panel.
@grtlr grtlr added ui concerns graphical user interface include in changelog 🔩 data model labels Jan 2, 2025
@grtlr grtlr requested a review from abey79 January 2, 2025 16:30
Copy link

github-actions bot commented Jan 2, 2025

Latest documentation preview deployed successfully.

Result Commit Link
327e6dc https://landing-m4fya0yso-rerun.vercel.app/docs

Note: This comment is updated whenever you push a commit.

Copy link

github-actions bot commented Jan 2, 2025

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
327e6dc https://rerun.io/viewer/pr/8567 +nightly +main

Note: This comment is updated whenever you push a commit.

@grtlr
Copy link
Contributor Author

grtlr commented Jan 7, 2025

I've updated the UI to show an icon, like we normally do. An example of this is in the diff.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems incorrect. it should truncate with the normally

Copy link
Member

@abey79 abey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code lgtm, but I'm a bit uncertain about the semantics here. A Uri very much feels like a datatype to me. For a component, you'd typically have SomethingUri.

I've seen the user request this originated with, and I'm wondering if the following approach would work:

  1. make Uri a datatype instead of a component
  2. make it so that one can log a custom component with a Uri datatype
  3. all Uri-based component are displayed as links

I'm not sure how bad it would be to have (2) though.

I don't feel super strongly about all this and wouldn't mind having it as is, but let's have @jleibs input first.

@jleibs
Copy link
Member

jleibs commented Jan 8, 2025

I generally agree with @abey79 's thought process, but can you point me at the user request for the additional context.

@grtlr
Copy link
Contributor Author

grtlr commented Jan 8, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔩 data model include in changelog ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants