-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add clickable URI component #8567
base: main
Are you sure you want to change the base?
Conversation
The component can be clicked in the tooltip and in the selection panel.
Latest documentation preview deployed successfully.
Note: This comment is updated whenever you push a commit. |
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
I've updated the UI to show an icon, like we normally do. An example of this is in the diff. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems incorrect. it should truncate with the …
normally
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code lgtm, but I'm a bit uncertain about the semantics here. A Uri
very much feels like a datatype to me. For a component, you'd typically have SomethingUri
.
I've seen the user request this originated with, and I'm wondering if the following approach would work:
- make
Uri
a datatype instead of a component - make it so that one can log a custom component with a
Uri
datatype - all
Uri
-based component are displayed as links
I'm not sure how bad it would be to have (2) though.
I don't feel super strongly about all this and wouldn't mind having it as is, but let's have @jleibs input first.
I generally agree with @abey79 's thought process, but can you point me at the user request for the additional context. |
@jleibs here is the Discord discussion: https://discord.com/channels/1062300748202921994/1320772574271115384/1320772574271115384 |
The component can be clicked in the tooltip and in the selection panel.