Extend and refactor log_point_cloud2 #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
przemb
force-pushed
the
pb_ext
branch
2 times, most recently
from
8c0afcd to
e4709bb
Compare
przemb
force-pushed
the
pb_ext
branch
2 times, most recently
from
012c8f3 to
4fae4d5
Compare
* log_point_cloud2 refactored to avoid redundant allocations * PointCloudProcessor and ColorMapper added * reversed colormap added * ColormapsLUT::supportedColormaps added * additional compilation flags added * rerun-sdk verison updated
|
Thanks for this PR! Do you have any before and after results for your use case when it comes to performance? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
log_point_cloud2()refactored to avoid redundant allocationsPointCloudProcessorandColorMapperaddedColormapsLUT::supportedColormapsadded_resolve_topic_optionsextended