-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reproducibility Report for H1lGHsA9KX #140
base: master
Are you sure you want to change the base?
Conversation
Hi, please find below a review submitted by one of the reviewers: Score: 7 Problem Statement (8): The report clearly shows an in-depth understanding of the problem statement of the original paper. The report was able to identify when the original authors were drifting from their initial aim as stated in the abstract of the original paper. Code (9): The report was also accompanied by with well written and properly commented/documented code. Hyperparameter Search (9): The authors went ahead to carry out additional experiments such as using the exact opposite loss for ratio loss and varying the positive hyperparameter β which ultimately questioned the relevance of the original paper Ablation Study (4): I'm unable to find any evidence of adequate ablation study in the report. Discussion on results (6): The report contains relatively detailed discussion on the state of reproducibility of the paper Recommendations for reproducibility (7): Relevant suggestions were also made to the original authors Overall organization and clarity (8): Overall organization is relatively fair. Little or no grammatical issues were found, plots were properly labelled and relevant/useful tables were included. Total points obtained: 59 Confidence : 4 |
Hi, please find below a review submitted by one of the reviewers: Score: 3 More details below: *Problem statement: well-understood In particular, I tried to rerun the main function in the repo, but got an error with both optimizers: *Communication with original authors: seems limited. Contacted authors for initialization. However, it remains unclear whether the report's authors have made sure that they are using the same architecture and other alg. parameters as in the paper (e.g., for Fig. 1). In particular, for those parameters that were not described in the original paper, did the authors in the report complete the missing information via communication with the authors? If yes, please clarify. *Hyperparameter Search: mostly impact of Beta parameter. The observation is indeed relevant. *Discussion on results: Extensive discussion. *Recommendations for reproducibility: Several recommendations issued. *Overall organization and clarity: the report raises interesting and relevant concerns at the beginning, but the argumentation is hard to follow in the implementation, specially Section 4, which should be more detailed. I suggest the report authors to clarify the writing, and make the report more detailed and self-contained. Which parameters/assumptions were used for each Figure? Which ones correspond to the original experiments? The report should be less coloquial. Avoid imperative sentences like: "It is not clear why the alg. works!" or "This amounts to the alg doing nothing!". Fig 1 & Fig 2: there is no strong convergence, in disagreement with the original paper. Could you dig more into the reason for that? I see too options: a) there is a bug in one of the code, or b) some hyperparameters are different between the original experiments and the reported ones. Is it a) or b)? |
Hi, please find below a review submitted by one of the reviewers: Score: 6 |
Issue Number: 91
Issue Link: #91