-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EPMRPP-90984 || Filter projects #4110
EPMRPP-90984 || Filter projects #4110
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/orgs #4110 +/- ##
=============================================
Coverage 61.97% 61.97%
=============================================
Files 85 85
Lines 960 960
Branches 142 141 -1
=============================================
Hits 595 595
Misses 334 334
Partials 31 31 ☔ View full report in Codecov by Sentry. |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this state be handled via CSS?
May be also ask UX team to add this icon to DC?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to use: fill, stroke, but it doesn't seem to work
@@ -129,6 +129,8 @@ export const URLS = { | |||
`${urlCommonBase}organizations${getQueryParams(preferencesObj)}`, | |||
organizationProjects: (organizationId, preferencesObj = {}) => | |||
`${urlCommonBase}organizations/${organizationId}/projects${getQueryParams(preferencesObj)}`, | |||
filterOrganizationProjects: (organizationId) => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May be adjust the name to be more consistent with endpoint name?
e.g. organizationProjectsSearches
@maria-hambardzumian Can we close this in favor of #4116? |
Closed in favor of #4116 |
PR Checklist
develop
for features/bugfixes, other if mentioned in the task)npm run lint
) prior to submission? Enable the git hook on commit in your IDE to run it and format the code automatically.npm run build
)?dev
npm script)manage:translations
script?Visuals