EPMRPP-90460 implement Organization Project endpoint #2004

grabsefx · 2024-06-05T08:52:06Z

add support of swagger code autogeneration
implemented Organization Project GET endpoint

github-actions · 2024-06-05T08:52:41Z

src/test/java/com/epam/ta/reportportal/ws/controller/OrganizationProjectControllerTest.java

+import com.epam.ta.reportportal.ws.BaseMvcTest;
+import org.junit.jupiter.api.Test;
+
+/**


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.javadoc.SummaryJavadocCheck> _{reported by reviewdog 🐶}
Summary javadoc is missing.

github-actions · 2024-06-05T08:52:41Z

src/main/java/com/epam/ta/reportportal/auth/permissions/OrganizationMemberPermission.java

+import org.springframework.security.oauth2.provider.OAuth2Authentication;
+import org.springframework.stereotype.Component;
+
+@Component("organizationMemberPermission")


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocTypeCheck> _{reported by reviewdog 🐶}
Missing a Javadoc comment.

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

reviewdog

src/main/java/com/epam/ta/reportportal/ws/controller/OrganizationController.java|107| Line is longer than 100 characters (found 207).
src/main/java/com/epam/ta/reportportal/ws/controller/OrganizationController.java|108| Line is longer than 100 characters (found 174).
src/main/java/com/epam/ta/reportportal/ws/controller/OrganizationController.java|109| Line is longer than 100 characters (found 222).
src/main/java/com/epam/ta/reportportal/core/project/impl/OrganizationProjectHandlerImpl.java|40 col 1| Missing a Javadoc comment.
src/main/java/com/epam/ta/reportportal/core/project/OrganizationProjectHandler.java|24 col 1| Missing a Javadoc comment.

github-actions · 2024-06-06T06:53:05Z

src/main/java/com/epam/ta/reportportal/auth/permissions/OrganizationMemberPermission.java

+    ReportPortalUser rpUser = (ReportPortalUser) oauth.getUserAuthentication().getPrincipal();
+    BusinessRule.expect(rpUser, Objects::nonNull).verify(ErrorType.ACCESS_DENIED);
+
+    var ou = organizationUserRepository.findByUserIdAndOrganization_Id(rpUser.getUserId(), (Long) orgId);


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> _{reported by reviewdog 🐶}
Line is longer than 100 characters (found 105).

github-actions · 2024-06-06T06:53:05Z

src/main/java/com/epam/ta/reportportal/util/ControllerUtils.java

@@ -109,4 +115,16 @@ public static MultiValuedMap<String, MultipartFile> getUploadedFiles(HttpServlet
    }
    return uploadedFiles;
  }
+
+  public static Direction parseSortDirection(String order) {


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocMethodCheck> _{reported by reviewdog 🐶}
Missing a Javadoc comment.

github-actions · 2024-06-06T06:53:05Z

src/main/java/com/epam/ta/reportportal/ws/controller/OrganizationProjectController.java

+import org.springframework.web.bind.annotation.RequestParam;
+import org.springframework.web.bind.annotation.RestController;
+
+@RestController


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocTypeCheck> _{reported by reviewdog 🐶}
Missing a Javadoc comment.

github-actions · 2024-06-06T06:53:06Z

src/main/java/com/epam/ta/reportportal/ws/controller/OrganizationProjectController.java

+   * @param order  The order in which to sort the result set. Can be 'asc' for ascending order or
+   *               'desc' for descending order.
+   * @return A ResponseEntity containing a list of projects associated with the specified
+   * organization.


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocTagContinuationIndentationCheck> _{reported by reviewdog 🐶}
Line continuation have incorrect indentation level, expected level should be 4.

github-actions · 2024-06-06T06:53:06Z

src/main/java/com/epam/ta/reportportal/ws/controller/OrganizationProjectController.java

+   */
+  @Transactional(readOnly = true)
+  @PreAuthorize(ORGANIZATION_MEMBER)
+  @Operation(summary = "Get organization projects", description = "Get a list of organization projects.  ### Authority:  - `ADMINISTRATOR` - `MANAGER` - `MEMBER`  ### Access level  - `ADMINISTRATOR` - no restrictions. - `MANAGER` - no restrictions. - `MEMBER` - restricted to viewing only their assigned projects.", security = {


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> _{reported by reviewdog 🐶}
Line is longer than 100 characters (found 328).

github-actions · 2024-06-06T06:53:07Z

src/main/java/com/epam/ta/reportportal/ws/controller/OrganizationController.java

+      @SecurityRequirement(name = "BearerAuth")}, tags = {"Organizations", "Ready for implementation"})
+  @ApiResponses(value = {
+      @ApiResponse(responseCode = "200", description = "OK", content = @Content(mediaType = "application/json", schema = @Schema(implementation = OrganizationProfilesList.class))),
+      @ApiResponse(responseCode = "400", description = "Bad Request", content = @Content(mediaType = "application/json", schema = @Schema(implementation = Problem.class))),


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> _{reported by reviewdog 🐶}
Line is longer than 100 characters (found 172).

github-actions · 2024-06-06T06:53:07Z

src/main/java/com/epam/ta/reportportal/ws/controller/OrganizationController.java

+  @ApiResponses(value = {
+      @ApiResponse(responseCode = "200", description = "OK", content = @Content(mediaType = "application/json", schema = @Schema(implementation = OrganizationProfilesList.class))),
+      @ApiResponse(responseCode = "400", description = "Bad Request", content = @Content(mediaType = "application/json", schema = @Schema(implementation = Problem.class))),
+      @ApiResponse(responseCode = "401", description = "Unauthorized", content = @Content(mediaType = "application/json", schema = @Schema(implementation = Problem.class)))})


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> _{reported by reviewdog 🐶}
Line is longer than 100 characters (found 174).

github-actions · 2024-06-06T06:53:07Z

src/main/java/com/epam/ta/reportportal/ws/controller/OrganizationController.java

+      produces = {"application/json"},
+      method = RequestMethod.GET)
+  public ResponseEntity<OrganizationProfilesList> getOrganizations(
+      @Parameter(in = ParameterIn.QUERY, description = "The offset used for this page of results", schema = @Schema(defaultValue = "0")) @Valid @RequestParam(value = "offset", required = false, defaultValue = "0") Integer offset,


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> _{reported by reviewdog 🐶}
Line is longer than 100 characters (found 229).

github-actions · 2024-06-06T06:53:07Z

src/main/java/com/epam/ta/reportportal/ws/controller/OrganizationController.java

+      method = RequestMethod.GET)
+  public ResponseEntity<OrganizationProfilesList> getOrganizations(
+      @Parameter(in = ParameterIn.QUERY, description = "The offset used for this page of results", schema = @Schema(defaultValue = "0")) @Valid @RequestParam(value = "offset", required = false, defaultValue = "0") Integer offset,
+      @Parameter(in = ParameterIn.QUERY, description = "The limit used for this page of results. This will be the same as the limit query parameter unless it exceeded the maximum value allowed for this API endpoint", schema = @Schema(defaultValue = "10")) @Valid @RequestParam(value = "limit", required = false, defaultValue = "10") Integer limit,


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> _{reported by reviewdog 🐶}
Line is longer than 100 characters (found 347).

github-actions · 2024-06-06T06:53:07Z

src/main/java/com/epam/ta/reportportal/ws/controller/OrganizationController.java

+  public ResponseEntity<OrganizationProfilesList> getOrganizations(
+      @Parameter(in = ParameterIn.QUERY, description = "The offset used for this page of results", schema = @Schema(defaultValue = "0")) @Valid @RequestParam(value = "offset", required = false, defaultValue = "0") Integer offset,
+      @Parameter(in = ParameterIn.QUERY, description = "The limit used for this page of results. This will be the same as the limit query parameter unless it exceeded the maximum value allowed for this API endpoint", schema = @Schema(defaultValue = "10")) @Valid @RequestParam(value = "limit", required = false, defaultValue = "10") Integer limit,
+      @Parameter(in = ParameterIn.QUERY, description = "Indicate sort by field", schema = @Schema()) @Valid @RequestParam(value = "sort", required = false) String sort,


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> _{reported by reviewdog 🐶}
Line is longer than 100 characters (found 168).

github-actions · 2024-06-07T07:21:21Z

src/main/java/com/epam/ta/reportportal/auth/permissions/OrganizationMemberPermission.java

+    ReportPortalUser rpUser = (ReportPortalUser) oauth.getUserAuthentication().getPrincipal();
+    BusinessRule.expect(rpUser, Objects::nonNull).verify(ErrorType.ACCESS_DENIED);
+
+    organizationRepositoryCustom.findById((Long) orgId).orElseThrow(() -> new ReportPortalException(ErrorType.ORGANIZATION_NOT_FOUND, orgId));


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> _{reported by reviewdog 🐶}
Line is longer than 100 characters (found 142).

github-actions · 2024-06-07T07:21:21Z

src/main/java/com/epam/ta/reportportal/ws/controller/OrganizationProjectController.java

+      method = RequestMethod.GET)
+  public ResponseEntity<OrganizationProjectsList> getOrganizationsOrgIdProjects(
+      @Parameter(in = ParameterIn.PATH, description = "Organization identifier", required = true, schema = @Schema()) @PathVariable("org_id") Long orgId,
+      @Parameter(in = ParameterIn.QUERY, description = "The limit used for this page of results. This will be the same as the limit query parameter unless it exceeded the maximum value allowed for this API endpoint", schema = @Schema(defaultValue = "300")) @Valid @RequestParam(value = "limit", required = false, defaultValue = "300") Integer limit,


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> _{reported by reviewdog 🐶}
Line is longer than 100 characters (found 349).

github-actions · 2024-06-07T07:21:22Z

src/main/java/com/epam/ta/reportportal/ws/controller/OrganizationProjectController.java

+      @Parameter(in = ParameterIn.PATH, description = "Organization identifier", required = true, schema = @Schema()) @PathVariable("org_id") Long orgId,
+      @Parameter(in = ParameterIn.QUERY, description = "The limit used for this page of results. This will be the same as the limit query parameter unless it exceeded the maximum value allowed for this API endpoint", schema = @Schema(defaultValue = "300")) @Valid @RequestParam(value = "limit", required = false, defaultValue = "300") Integer limit,
+      @Parameter(in = ParameterIn.QUERY, description = "The offset used for this page of results", schema = @Schema(defaultValue = "0")) @Valid @RequestParam(value = "offset", required = false, defaultValue = "0") Integer offset,
+      @Parameter(in = ParameterIn.QUERY, description = "Indicate sorting direction", schema = @Schema(allowableValues = {"ASC", "DESC"}, defaultValue = "ASC")) @Valid @RequestParam(value = "order", required = false, defaultValue = "ASC") String order,


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> _{reported by reviewdog 🐶}
Line is longer than 100 characters (found 251).

github-actions · 2024-06-07T07:21:22Z

src/main/java/com/epam/ta/reportportal/ws/controller/OrganizationProjectController.java

+      @Parameter(in = ParameterIn.QUERY, description = "Indicate sorting direction", schema = @Schema(allowableValues = {"ASC", "DESC"}, defaultValue = "ASC")) @Valid @RequestParam(value = "order", required = false, defaultValue = "ASC") String order,
+      @Parameter(in = ParameterIn.QUERY, description = "Filter projects by name", schema = @Schema()) @Valid @RequestParam(value = "name", required = false) String name,
+      @Pattern(regexp = "^[a-z0-9]+(?:-[a-z0-9]+)*$") @Parameter(in = ParameterIn.QUERY, description = "Filter projects by slug", schema = @Schema()) @Valid @RequestParam(value = "slug", required = false) String slug,
+      @Parameter(in = ParameterIn.QUERY, description = "Indicate sort by field", schema = @Schema(defaultValue = "name")) @Valid @RequestParam(value = "sort", required = false, defaultValue = "name") String sort,


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> _{reported by reviewdog 🐶}
Line is longer than 100 characters (found 212).

github-actions · 2024-06-07T07:21:22Z

src/main/java/com/epam/ta/reportportal/ws/controller/OrganizationController.java

+  @Operation(summary = "Get organization information", description = "Provide organization information.  ### Authority:  - `ADMINISTRATOR` - `MANAGER` - `MEMBER`", security = {
+      @SecurityRequirement(name = "BearerAuth")}, tags = {"Organizations", "Ready for implementation"})
+  @ApiResponses(value = {
+      @ApiResponse(responseCode = "200", description = "OK", content = @Content(mediaType = "application/json", schema = @Schema(implementation = OrganizationProfile.class))),


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> _{reported by reviewdog 🐶}
Line is longer than 100 characters (found 175).

github-actions · 2024-06-07T07:21:22Z

src/main/java/com/epam/ta/reportportal/ws/controller/OrganizationController.java

+      @Parameter(in = ParameterIn.QUERY, description = "The offset used for this page of results", schema = @Schema(defaultValue = "0")) @Valid @RequestParam(value = "offset", required = false, defaultValue = "0") Integer offset,
+      @Parameter(in = ParameterIn.QUERY, description = "The limit used for this page of results. This will be the same as the limit query parameter unless it exceeded the maximum value allowed for this API endpoint", schema = @Schema(defaultValue = "300")) @Valid @RequestParam(value = "limit", required = false, defaultValue = "300") Integer limit,
+      @Parameter(in = ParameterIn.QUERY, description = "Indicate sorting direction", schema = @Schema(allowableValues = {"ASC", "DESC"}, defaultValue = "ASC")) @Valid @RequestParam(value = "order", required = false, defaultValue = "ASC") String order,
+      @Parameter(in = ParameterIn.QUERY, description = "Filter organizations by name", schema = @Schema()) @Valid @RequestParam(value = "name", required = false) String name,


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> _{reported by reviewdog 🐶}
Line is longer than 100 characters (found 174).

github-actions · 2024-06-07T07:21:22Z

src/main/java/com/epam/ta/reportportal/ws/controller/OrganizationController.java

+      @Parameter(in = ParameterIn.QUERY, description = "The limit used for this page of results. This will be the same as the limit query parameter unless it exceeded the maximum value allowed for this API endpoint", schema = @Schema(defaultValue = "300")) @Valid @RequestParam(value = "limit", required = false, defaultValue = "300") Integer limit,
+      @Parameter(in = ParameterIn.QUERY, description = "Indicate sorting direction", schema = @Schema(allowableValues = {"ASC", "DESC"}, defaultValue = "ASC")) @Valid @RequestParam(value = "order", required = false, defaultValue = "ASC") String order,
+      @Parameter(in = ParameterIn.QUERY, description = "Filter organizations by name", schema = @Schema()) @Valid @RequestParam(value = "name", required = false) String name,
+      @Pattern(regexp = "^[a-z0-9]+(?:-[a-z0-9]+)*$") @Parameter(in = ParameterIn.QUERY, description = "Filter organizations by slug", schema = @Schema()) @Valid @RequestParam(value = "slug", required = false) String slug,


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> _{reported by reviewdog 🐶}
Line is longer than 100 characters (found 222).

github-actions · 2024-06-07T07:21:22Z

src/main/java/com/epam/ta/reportportal/ws/controller/OrganizationController.java

+      @Parameter(in = ParameterIn.QUERY, description = "Indicate sorting direction", schema = @Schema(allowableValues = {"ASC", "DESC"}, defaultValue = "ASC")) @Valid @RequestParam(value = "order", required = false, defaultValue = "ASC") String order,
+      @Parameter(in = ParameterIn.QUERY, description = "Filter organizations by name", schema = @Schema()) @Valid @RequestParam(value = "name", required = false) String name,
+      @Pattern(regexp = "^[a-z0-9]+(?:-[a-z0-9]+)*$") @Parameter(in = ParameterIn.QUERY, description = "Filter organizations by slug", schema = @Schema()) @Valid @RequestParam(value = "slug", required = false) String slug,
+      @Parameter(in = ParameterIn.QUERY, description = "Indicate sort by field", schema = @Schema(defaultValue = "name")) @Valid @RequestParam(value = "sort", required = false, defaultValue = "name") String sort,


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> _{reported by reviewdog 🐶}
Line is longer than 100 characters (found 212).

github-actions · 2024-06-07T07:21:22Z

src/main/java/com/epam/ta/reportportal/core/project/impl/OrganizationProjectHandlerImpl.java

+import org.springframework.data.domain.Pageable;
+import org.springframework.stereotype.Service;
+
+@Service


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocTypeCheck> _{reported by reviewdog 🐶}
Missing a Javadoc comment.

github-actions · 2024-06-07T07:21:22Z

src/main/java/com/epam/ta/reportportal/core/project/OrganizationProjectHandler.java

-  private OrganizationConverter() {
-    //static only
-  }
+public interface OrganizationProjectHandler {


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocTypeCheck> _{reported by reviewdog 🐶}
Missing a Javadoc comment.

pbortnik · 2024-06-10T15:07:28Z

src/main/java/com/epam/ta/reportportal/auth/permissions/OrganizationMemberPermission.java

+  private final OrganizationRepositoryCustom organizationRepositoryCustom;
+
+
+  @Autowired


Can be used @requiredargsconstructor from lombok to clean up code

grabsefx added 2 commits May 31, 2024 15:04

EPMRPP-90460 add git module

50a1c45

EPMRPP-90460 implement Organization Project endpoint

96b2831

grabsefx requested a review from avarabyeu as a code owner June 5, 2024 08:52

github-actions bot reviewed Jun 5, 2024

View reviewed changes

reportportal deleted a comment from github-actions bot Jun 5, 2024

EPMRPP-90460 update reportportal-common-api submodule

685eb05

reportportal deleted a comment from github-actions bot Jun 5, 2024

EPMRPP-90460 update controllers according to documentation

045ffe4

github-actions bot reviewed Jun 6, 2024

View reviewed changes

EPMRPP-90460 update controllers according to documentation

3288a26

github-actions bot reviewed Jun 7, 2024

View reviewed changes

grabsefx added 2 commits June 7, 2024 13:32

EPMRPP-90460 update controllers according to documentation

333caa1

EPMRPP-90460 update dependencies

ea86934

grabsefx self-assigned this Jun 10, 2024

pbortnik approved these changes Jun 10, 2024

View reviewed changes

grabsefx merged commit 60ab456 into feature/orgs Jun 10, 2024
6 of 7 checks passed

grabsefx deleted the EPMRPP-90460 branch June 10, 2024 15:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

EPMRPP-90460 implement Organization Project endpoint #2004

EPMRPP-90460 implement Organization Project endpoint #2004

grabsefx commented Jun 5, 2024

github-actions bot Jun 5, 2024

github-actions bot Jun 5, 2024

github-actions bot left a comment

github-actions bot Jun 6, 2024

github-actions bot Jun 6, 2024

github-actions bot Jun 6, 2024

github-actions bot Jun 6, 2024

github-actions bot Jun 6, 2024

github-actions bot Jun 6, 2024

github-actions bot Jun 6, 2024

github-actions bot Jun 6, 2024

github-actions bot Jun 6, 2024

github-actions bot Jun 6, 2024

github-actions bot Jun 7, 2024

github-actions bot Jun 7, 2024

github-actions bot Jun 7, 2024

github-actions bot Jun 7, 2024

github-actions bot Jun 7, 2024

github-actions bot Jun 7, 2024

github-actions bot Jun 7, 2024

github-actions bot Jun 7, 2024

github-actions bot Jun 7, 2024

github-actions bot Jun 7, 2024

pbortnik Jun 10, 2024

		private final OrganizationRepositoryCustom organizationRepositoryCustom;


		@Autowired

EPMRPP-90460 implement Organization Project endpoint #2004

EPMRPP-90460 implement Organization Project endpoint #2004

Conversation

grabsefx commented Jun 5, 2024

github-actions bot Jun 5, 2024

Choose a reason for hiding this comment

github-actions bot Jun 5, 2024

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Jun 6, 2024

Choose a reason for hiding this comment

github-actions bot Jun 6, 2024

Choose a reason for hiding this comment

github-actions bot Jun 6, 2024

Choose a reason for hiding this comment

github-actions bot Jun 6, 2024

Choose a reason for hiding this comment

github-actions bot Jun 6, 2024

Choose a reason for hiding this comment

github-actions bot Jun 6, 2024

Choose a reason for hiding this comment

github-actions bot Jun 6, 2024

Choose a reason for hiding this comment

github-actions bot Jun 6, 2024

Choose a reason for hiding this comment

github-actions bot Jun 6, 2024

Choose a reason for hiding this comment

github-actions bot Jun 6, 2024

Choose a reason for hiding this comment

github-actions bot Jun 7, 2024

Choose a reason for hiding this comment

github-actions bot Jun 7, 2024

Choose a reason for hiding this comment

github-actions bot Jun 7, 2024

Choose a reason for hiding this comment

github-actions bot Jun 7, 2024

Choose a reason for hiding this comment

github-actions bot Jun 7, 2024

Choose a reason for hiding this comment

github-actions bot Jun 7, 2024

Choose a reason for hiding this comment

github-actions bot Jun 7, 2024

Choose a reason for hiding this comment

github-actions bot Jun 7, 2024

Choose a reason for hiding this comment

github-actions bot Jun 7, 2024

Choose a reason for hiding this comment

github-actions bot Jun 7, 2024

Choose a reason for hiding this comment

pbortnik Jun 10, 2024

Choose a reason for hiding this comment