EPMRPP-89420 implement organizations sort and filter #1929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
src/main/java/com/epam/ta/reportportal/core/organization/GetOrganizationHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/com/epam/ta/reportportal/core/organization/GetOrganizationHandler.java
Show resolved
Hide resolved
IvanKustau
reviewed
Feb 27, 2024
|
|
||
| @Autowired | ||
| public CreateProjectHandlerImpl(PersonalProjectService personalProjectService, | ||
| ProjectRepository projectRepository, UserRepository userRepository, | ||
| AttributeRepository attributeRepository, IssueTypeRepository issueTypeRepository, | ||
| ApplicationEventPublisher applicationEventPublisher, | ||
| ProjectUserRepository projectUserRepository, OrganizationRepository organizationRepository) { | ||
| ProjectUserRepository projectUserRepository, | ||
| OrganizationRepositoryCustom organizationRepositoryCustom) { |
There was a problem hiding this comment.
Usage of a Custom repository looks a little bit strange for me, can't we extend OrganizationRepositoryCustom from OrganizationRepository and use it as an interface? If we can't, then this is OK for me
There was a problem hiding this comment.
In this case we have to provide read-only access to the database. OrganizationRepository will open access to all CRUD operations
IvanKustau
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.