Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPMRPP-89396 || EPMRPP-89397 || EPMRPP-89395 || Change batch endpoint #1928

Merged
merged 4 commits into from
Feb 29, 2024

Conversation

APiankouski
Copy link
Contributor

No description provided.

* @param user User
* @return DeleteLaunchesRS
*/
DeleteBulkRS deleteLaunches(List<Long> ids,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interface implementation class should be updated accordingly

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DeleteBulkRS - response of api don't change

@@ -123,14 +124,14 @@ public OperationCompletionRS deleteLaunch(Long launchId,
return new OperationCompletionRS("Launch with ID = '" + launchId + "' successfully deleted.");
}

public DeleteBulkRS deleteLaunches(DeleteBulkRQ deleteBulkRQ,
public DeleteBulkRS deleteLaunches(List<Long> ids,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocMethodCheck> reported by reviewdog 🐶
Missing a Javadoc comment.

@APiankouski APiankouski merged commit f5b0d9c into develop Feb 29, 2024
3 of 4 checks passed
@APiankouski APiankouski deleted the EPMRPP-89395-batch-endpoint branch February 29, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants