Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPMRPP-89198 routing refactor #1926

Merged
merged 17 commits into from
Feb 26, 2024
Merged

Conversation

grabsefx
Copy link
Contributor

No description provided.

@grabsefx grabsefx requested a review from avarabyeu as a code owner February 14, 2024 08:33
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

reviewdog

src/main/java/com/epam/ta/reportportal/util/SlugifyUtils.java|5 col 1| Missing a Javadoc comment.
src/main/java/com/epam/ta/reportportal/util/ProjectExtractor.java|90| Line is longer than 100 characters (found 104).
src/main/java/com/epam/ta/reportportal/ws/converter/converters/UserConverter.java|80| Line is longer than 100 characters (found 113).
src/main/java/com/epam/ta/reportportal/ws/converter/converters/OrganizationConverter.java|23| Summary javadoc is missing.
src/main/java/com/epam/ta/reportportal/ws/converter/converters/OrganizationConverter.java|33| Line is longer than 100 characters (found 102).
src/main/java/com/epam/ta/reportportal/ws/controller/OrganizationController.java|32| Summary javadoc is missing.
src/main/java/com/epam/ta/reportportal/ws/controller/ActivityController.java|38 col 2| 'import' has incorrect indentation level 1, expected level should be 0.
src/main/java/com/epam/ta/reportportal/ws/controller/ActivityController.java|48 col 2| 'class def modifier' has incorrect indentation level 1, expected level should be 0.
src/main/java/com/epam/ta/reportportal/ws/controller/ActivityController.java|63 col 4| 'method def modifier' has incorrect indentation level 3, expected level should be 2.
src/main/java/com/epam/ta/reportportal/ws/controller/ActivityController.java|63 col 4| Missing a Javadoc comment.
src/main/java/com/epam/ta/reportportal/ws/controller/ActivityController.java|72 col 4| 'method def modifier' has incorrect indentation level 3, expected level should be 2.
src/main/java/com/epam/ta/reportportal/ws/controller/ActivityController.java|72 col 4| Missing a Javadoc comment.
src/main/java/com/epam/ta/reportportal/ws/controller/ActivityController.java|82 col 2| 'class def rcurly' has incorrect indentation level 1, expected level should be 0.
src/main/java/com/epam/ta/reportportal/model/project/ProjectResource.java|81 col 3| Missing a Javadoc comment.
src/main/java/com/epam/ta/reportportal/model/user/UserResource.java|75 col 3| Missing a Javadoc comment.
src/main/java/com/epam/ta/reportportal/model/user/UserResource.java|86 col 3| Missing a Javadoc comment.
src/test/java/com/epam/ta/reportportal/OrganizationUtil.java|23| Summary javadoc is missing.
src/test/java/com/epam/ta/reportportal/core/project/settings/impl/CreateProjectSettingsHandlerImplTest.java|71| Line is longer than 100 characters (found 101).
src/test/java/com/epam/ta/reportportal/core/project/settings/impl/DeleteProjectSettingsHandlerImplTest.java|63| Line is longer than 100 characters (found 101).
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|114 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|114 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|116 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|116 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|118| Line is longer than 100 characters (found 146).
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|118 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|118 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|125 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|125 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|128| Line is longer than 100 characters (found 101).
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|128 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|128 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|131| Line is longer than 100 characters (found 146).
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|131 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|131 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|141| Line is longer than 100 characters (found 143).
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|141 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|141 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|144| Line is longer than 100 characters (found 152).
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|144 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|144 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|151 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|151 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|155| Line is longer than 100 characters (found 138).
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|155 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|155 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|161| Line is longer than 100 characters (found 146).
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|161 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|161 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|168 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|168 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|181 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|181 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|182| Line is longer than 100 characters (found 101).
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|182 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|182 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|188| Line is longer than 100 characters (found 102).
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|188 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|188 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|193| Line is longer than 100 characters (found 138).
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|193 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|193 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|199 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|199 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/project/impl/GetProjectHandlerImplTest.java|132| Line is longer than 100 characters (found 117).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|80| Line is longer than 100 characters (found 119).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|80 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|97| Line is longer than 100 characters (found 115).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|97 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|100| Line is longer than 100 characters (found 119).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|100 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|119| Line is longer than 100 characters (found 137).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|119 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|122| Line is longer than 100 characters (found 119).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|122 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|138| Line is longer than 100 characters (found 119).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|138 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|146| Line is longer than 100 characters (found 142).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|146 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|163| Line is longer than 100 characters (found 141).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|163 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|172| Line is longer than 100 characters (found 142).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|172 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|194| Line is longer than 100 characters (found 119).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|194 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|197| Line is longer than 100 characters (found 123).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|197 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|213 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|214| Line is longer than 100 characters (found 122).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|214 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|223| Line is longer than 100 characters (found 142).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|223 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|226| Line is longer than 100 characters (found 135).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|226 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|226 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|242| Line is longer than 100 characters (found 143).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|242 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|242 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|252| Line is longer than 100 characters (found 142).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|252 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|272| Line is longer than 100 characters (found 143).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|272 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|272 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|282| Line is longer than 100 characters (found 142).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|282 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/StartTestItemHandlerImplTest.java|164| Line is longer than 100 characters (found 102).
src/test/java/com/epam/ta/reportportal/core/item/impl/UpdateTestItemHandlerImplTest.java|212| Line is longer than 100 characters (found 101).
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|122 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|122 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|130| Line is longer than 100 characters (found 101).
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|130 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|130 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|139 col 9| 'TEST_PROJECT_KEY' has incorrect indentation level 8, expected level should be 20.
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|158 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|158 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|166| Line is longer than 100 characters (found 101).
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|166 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|166 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|175 col 9| 'TEST_PROJECT_KEY' has incorrect indentation level 8, expected level should be 20.
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|182| Line is longer than 100 characters (found 139).
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|182 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/filter/impl/UpdateUserFilterHandlerTest.java|86| Line is longer than 100 characters (found 101).
src/test/java/com/epam/ta/reportportal/core/filter/impl/UpdateUserFilterHandlerTest.java|114| Line is longer than 100 characters (found 101).
src/test/java/com/epam/ta/reportportal/core/filter/impl/UpdateUserFilterHandlerTest.java|146| Line is longer than 100 characters (found 101).
src/test/java/com/epam/ta/reportportal/core/launch/impl/GetLaunchHandlerImplTest.java|238| Line is longer than 100 characters (found 102).
src/test/java/com/epam/ta/reportportal/core/launch/impl/FinishLaunchHandlerImplTest.java|99| Line is longer than 100 characters (found 101).
src/test/java/com/epam/ta/reportportal/core/launch/impl/FinishLaunchHandlerImplTest.java|121| Line is longer than 100 characters (found 101).
src/test/java/com/epam/ta/reportportal/core/launch/impl/FinishLaunchHandlerImplTest.java|169| Line is longer than 100 characters (found 102).
src/test/java/com/epam/ta/reportportal/core/launch/impl/UpdateLaunchHandlerImplTest.java|161| Line is longer than 100 characters (found 102).
src/test/java/com/epam/ta/reportportal/core/analyzer/auto/impl/SearchLogServiceImplTest.java|92| Line is longer than 100 characters (found 103).
src/test/java/com/epam/ta/reportportal/ws/converter/converters/UserConverterTest.java|53| Line is longer than 100 characters (found 101).
src/test/java/com/epam/ta/reportportal/ws/converter/converters/OrganizationConverterTest.java|28| Summary javadoc is missing.
src/test/java/com/epam/ta/reportportal/ws/converter/converters/OrganizationConverterTest.java|47| Line is longer than 100 characters (found 112).
src/test/java/com/epam/ta/reportportal/ws/controller/ProjectControllerTest.java|157 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/ws/controller/ProjectControllerTest.java|157 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/ws/controller/ProjectControllerTest.java|321 col 3| Annotation 'Disabled' have incorrect indentation level 2, expected level should be 1.
src/test/java/com/epam/ta/reportportal/ws/controller/ProjectControllerTest.java|361 col 3| Annotation 'Disabled' have incorrect indentation level 2, expected level should be 1.
src/test/java/com/epam/ta/reportportal/ws/controller/OrganizationControllerTest.java|25| Summary javadoc is missing.

@@ -29,20 +29,15 @@ private Permissions() {

public static final String ADMIN_ONLY = "hasRole('ADMINISTRATOR')";

public static final String ALLOWED_TO_EDIT_USER =
"(#login.toLowerCase() == authentication.name)" + "||" + ADMIN_ONLY;
public static final String ALLOWED_TO_EDIT_USER = "(#login.toLowerCase() == authentication.name)" + "||" + ADMIN_ONLY;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 100 characters (found 120).


public static final String ALLOWED_TO_REPORT =
"hasPermission(#projectName.toLowerCase(), 'reporterPermission')" + "||" + ADMIN_ONLY;
public static final String ALLOWED_TO_REPORT = "hasPermission(#projectKey.toLowerCase(), 'reporterPermission')" + "||" + ADMIN_ONLY;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 100 characters (found 134).


public static final String ASSIGNED_TO_PROJECT = "hasPermission(#projectName.toLowerCase(), 'isAssignedToProject')";
public static final String ASSIGNED_TO_PROJECT = "hasPermission(#projectKey.toLowerCase(), 'isAssignedToProject')";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 100 characters (found 117).


public static final String PROJECT_MANAGER =
"hasPermission(#projectName.toLowerCase(), 'projectManagerPermission')" + "||" + ADMIN_ONLY;
public static final String PROJECT_MANAGER = "hasPermission(#projectKey.toLowerCase(), 'projectManagerPermission')" + "||" + ADMIN_ONLY;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 100 characters (found 138).


public static final String NOT_CUSTOMER =
"hasPermission(#projectName.toLowerCase(), 'notCustomerPermission')" + "||" + ADMIN_ONLY;
public static final String NOT_CUSTOMER = "hasPermission(#projectKey.toLowerCase(), 'notCustomerPermission')" + "||" + ADMIN_ONLY;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 100 characters (found 132).

@@ -48,8 +52,8 @@ class DemoDataController {

@PostMapping("/generate")
@ApiOperation(value = "generate")
public DemoDataRs generate(@PathVariable String projectName, @Validated @RequestBody DemoDataRq demoDataRq,
public DemoDataRs generate(@PathVariable String projectKey, @Validated @RequestBody DemoDataRq demoDataRq,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 100 characters (found 114).

@@ -48,8 +52,8 @@

@PostMapping("/generate")
@ApiOperation(value = "generate")
public DemoDataRs generate(@PathVariable String projectName, @Validated @RequestBody DemoDataRq demoDataRq,
public DemoDataRs generate(@PathVariable String projectKey, @Validated @RequestBody DemoDataRq demoDataRq,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

@AuthenticationPrincipal ReportPortalUser user) {
return demoDataService.generate(demoDataRq, projectExtractor.extractProjectDetailsAdmin(user, projectName), user);
return demoDataService.generate(demoDataRq, projectExtractor.extractProjectDetailsAdmin(user, projectKey), user);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 100 characters (found 129).

@AuthenticationPrincipal ReportPortalUser user) {
return demoDataService.generate(demoDataRq, projectExtractor.extractProjectDetailsAdmin(user, projectName), user);
return demoDataService.generate(demoDataRq, projectExtractor.extractProjectDetailsAdmin(user, projectKey), user);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

@AuthenticationPrincipal ReportPortalUser user) {
return demoDataService.generate(demoDataRq, projectExtractor.extractProjectDetailsAdmin(user, projectName), user);
return demoDataService.generate(demoDataRq, projectExtractor.extractProjectDetailsAdmin(user, projectKey), user);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'method def' child has incorrect indentation level 16, expected level should be 4.

@grabsefx grabsefx self-assigned this Feb 14, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

reviewdog

src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|128 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|131| Line is longer than 100 characters (found 146).
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|131 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|131 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|141| Line is longer than 100 characters (found 143).
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|141 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|141 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|144| Line is longer than 100 characters (found 152).
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|144 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|144 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|151 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|151 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|155| Line is longer than 100 characters (found 138).
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|155 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|155 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|161| Line is longer than 100 characters (found 146).
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|161 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|161 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|168 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|168 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|181 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|181 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|182| Line is longer than 100 characters (found 101).
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|182 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|182 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|188| Line is longer than 100 characters (found 102).
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|188 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|188 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|193| Line is longer than 100 characters (found 138).
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|193 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|193 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|199 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|199 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/project/impl/GetProjectHandlerImplTest.java|132| Line is longer than 100 characters (found 117).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|80| Line is longer than 100 characters (found 119).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|80 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|97| Line is longer than 100 characters (found 115).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|97 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|100| Line is longer than 100 characters (found 119).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|100 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|119| Line is longer than 100 characters (found 137).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|119 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|122| Line is longer than 100 characters (found 119).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|122 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|138| Line is longer than 100 characters (found 119).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|138 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|146| Line is longer than 100 characters (found 142).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|146 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|163| Line is longer than 100 characters (found 141).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|163 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|172| Line is longer than 100 characters (found 142).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|172 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|194| Line is longer than 100 characters (found 119).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|194 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|197| Line is longer than 100 characters (found 123).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|197 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|213 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|214| Line is longer than 100 characters (found 122).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|214 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|223| Line is longer than 100 characters (found 142).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|223 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|226| Line is longer than 100 characters (found 135).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|226 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|226 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|242| Line is longer than 100 characters (found 143).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|242 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|242 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|252| Line is longer than 100 characters (found 142).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|252 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|272| Line is longer than 100 characters (found 143).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|272 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|272 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|282| Line is longer than 100 characters (found 142).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|282 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/StartTestItemHandlerImplTest.java|164| Line is longer than 100 characters (found 102).
src/test/java/com/epam/ta/reportportal/core/item/impl/UpdateTestItemHandlerImplTest.java|212| Line is longer than 100 characters (found 101).
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|122 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|122 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|130| Line is longer than 100 characters (found 101).
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|130 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|130 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|139 col 9| 'TEST_PROJECT_KEY' has incorrect indentation level 8, expected level should be 20.
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|158 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|158 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|166| Line is longer than 100 characters (found 101).
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|166 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|166 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|175 col 9| 'TEST_PROJECT_KEY' has incorrect indentation level 8, expected level should be 20.
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|182| Line is longer than 100 characters (found 139).
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|182 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/filter/impl/UpdateUserFilterHandlerTest.java|86| Line is longer than 100 characters (found 101).
src/test/java/com/epam/ta/reportportal/core/filter/impl/UpdateUserFilterHandlerTest.java|114| Line is longer than 100 characters (found 101).
src/test/java/com/epam/ta/reportportal/core/filter/impl/UpdateUserFilterHandlerTest.java|146| Line is longer than 100 characters (found 101).
src/test/java/com/epam/ta/reportportal/core/launch/impl/GetLaunchHandlerImplTest.java|238| Line is longer than 100 characters (found 102).
src/test/java/com/epam/ta/reportportal/core/launch/impl/FinishLaunchHandlerImplTest.java|99| Line is longer than 100 characters (found 101).
src/test/java/com/epam/ta/reportportal/core/launch/impl/FinishLaunchHandlerImplTest.java|121| Line is longer than 100 characters (found 101).
src/test/java/com/epam/ta/reportportal/core/launch/impl/FinishLaunchHandlerImplTest.java|169| Line is longer than 100 characters (found 102).
src/test/java/com/epam/ta/reportportal/core/launch/impl/UpdateLaunchHandlerImplTest.java|161| Line is longer than 100 characters (found 102).
src/test/java/com/epam/ta/reportportal/core/analyzer/auto/impl/SearchLogServiceImplTest.java|92| Line is longer than 100 characters (found 103).
src/test/java/com/epam/ta/reportportal/ws/converter/converters/UserConverterTest.java|53| Line is longer than 100 characters (found 101).
src/test/java/com/epam/ta/reportportal/ws/converter/converters/OrganizationConverterTest.java|28| Summary javadoc is missing.
src/test/java/com/epam/ta/reportportal/ws/converter/converters/OrganizationConverterTest.java|47| Line is longer than 100 characters (found 112).
src/test/java/com/epam/ta/reportportal/ws/controller/ProjectControllerTest.java|157 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/ws/controller/ProjectControllerTest.java|157 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/ws/controller/ProjectControllerTest.java|321 col 3| Annotation 'Disabled' have incorrect indentation level 2, expected level should be 1.
src/test/java/com/epam/ta/reportportal/ws/controller/ProjectControllerTest.java|361 col 3| Annotation 'Disabled' have incorrect indentation level 2, expected level should be 1.
src/test/java/com/epam/ta/reportportal/ws/controller/OrganizationControllerTest.java|25| Summary javadoc is missing.


import com.github.slugify.Slugify;

public class SlugifyUtils {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocTypeCheck> reported by reviewdog 🐶
Missing a Javadoc comment.

ReportPortalUser.ProjectDetails projectDetails = projectUserRepository.findAdminDetailsProjectName(
normalizeId(projectName))
.orElseThrow(() -> new ReportPortalException(ErrorType.PROJECT_NOT_FOUND, projectName));
ReportPortalUser.ProjectDetails projectDetails = projectUserRepository.findAdminDetailsProjectKey(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 100 characters (found 104).

.stream()
.collect(Collectors.toMap(orgUser -> orgUser.getOrganization().getSlug(),
orgUser -> {
UserResource.AssignedOrganization assignedOrganization = new UserResource.AssignedOrganization();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 100 characters (found 113).

import com.epam.ta.reportportal.model.OrganizationResource;
import java.util.function.Function;

/**

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.javadoc.SummaryJavadocCheck> reported by reviewdog 🐶
Summary javadoc is missing.

}


public static final Function<Organization, OrganizationResource> TO_ORGANIZATION_RESOURCE = org -> {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 100 characters (found 102).


ReportPortalException exception = assertThrows(ReportPortalException.class, () -> handler.deleteProjectIndex(projectName, "user"));
ReportPortalException exception = assertThrows(ReportPortalException.class, () -> handler.deleteProjectIndex(projectKey, "user"));

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'method def' child has incorrect indentation level 16, expected level should be 4.


assertEquals("Project 'notExist' not found. Did you use correct project name?", exception.getMessage());
}

@Test
void deleteProjectIndexByNotExistUser() {
String projectName = "notExist";
String projectKey = "notExist";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.


assertEquals("Project 'notExist' not found. Did you use correct project name?", exception.getMessage());
}

@Test
void deleteProjectIndexByNotExistUser() {
String projectName = "notExist";
String projectKey = "notExist";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'method def' child has incorrect indentation level 16, expected level should be 4.

String userName = "user";
when(analyzerServiceClient.hasClients()).thenReturn(true);
when(projectRepository.findByName(projectName)).thenReturn(Optional.of(new Project()));
when(projectRepository.findByKey(projectKey)).thenReturn(Optional.of(new Project()));

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 100 characters (found 101).

String userName = "user";
when(analyzerServiceClient.hasClients()).thenReturn(true);
when(projectRepository.findByName(projectName)).thenReturn(Optional.of(new Project()));
when(projectRepository.findByKey(projectKey)).thenReturn(Optional.of(new Project()));

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

reviewdog

src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|193 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|199 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|199 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/project/impl/GetProjectHandlerImplTest.java|132| Line is longer than 100 characters (found 117).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|80| Line is longer than 100 characters (found 119).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|80 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|97| Line is longer than 100 characters (found 115).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|97 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|100| Line is longer than 100 characters (found 119).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|100 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|119| Line is longer than 100 characters (found 137).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|119 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|122| Line is longer than 100 characters (found 119).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|122 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|138| Line is longer than 100 characters (found 119).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|138 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|146| Line is longer than 100 characters (found 142).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|146 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|163| Line is longer than 100 characters (found 141).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|163 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|172| Line is longer than 100 characters (found 142).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|172 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|194| Line is longer than 100 characters (found 119).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|194 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|197| Line is longer than 100 characters (found 123).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|197 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|213 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|214| Line is longer than 100 characters (found 122).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|214 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|223| Line is longer than 100 characters (found 142).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|223 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|226| Line is longer than 100 characters (found 135).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|226 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|226 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|242| Line is longer than 100 characters (found 143).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|242 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|242 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|252| Line is longer than 100 characters (found 142).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|252 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|272| Line is longer than 100 characters (found 143).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|272 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|272 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|282| Line is longer than 100 characters (found 142).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|282 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/StartTestItemHandlerImplTest.java|164| Line is longer than 100 characters (found 102).
src/test/java/com/epam/ta/reportportal/core/item/impl/UpdateTestItemHandlerImplTest.java|212| Line is longer than 100 characters (found 101).
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|122 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|122 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|130| Line is longer than 100 characters (found 101).
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|130 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|130 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|139 col 9| 'TEST_PROJECT_KEY' has incorrect indentation level 8, expected level should be 20.
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|158 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|158 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|166| Line is longer than 100 characters (found 101).
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|166 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|166 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|175 col 9| 'TEST_PROJECT_KEY' has incorrect indentation level 8, expected level should be 20.
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|182| Line is longer than 100 characters (found 139).
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|182 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/filter/impl/UpdateUserFilterHandlerTest.java|86| Line is longer than 100 characters (found 101).
src/test/java/com/epam/ta/reportportal/core/filter/impl/UpdateUserFilterHandlerTest.java|114| Line is longer than 100 characters (found 101).
src/test/java/com/epam/ta/reportportal/core/filter/impl/UpdateUserFilterHandlerTest.java|146| Line is longer than 100 characters (found 101).
src/test/java/com/epam/ta/reportportal/core/launch/impl/GetLaunchHandlerImplTest.java|238| Line is longer than 100 characters (found 102).
src/test/java/com/epam/ta/reportportal/core/launch/impl/FinishLaunchHandlerImplTest.java|99| Line is longer than 100 characters (found 101).
src/test/java/com/epam/ta/reportportal/core/launch/impl/FinishLaunchHandlerImplTest.java|121| Line is longer than 100 characters (found 101).
src/test/java/com/epam/ta/reportportal/core/launch/impl/FinishLaunchHandlerImplTest.java|169| Line is longer than 100 characters (found 102).
src/test/java/com/epam/ta/reportportal/core/launch/impl/UpdateLaunchHandlerImplTest.java|161| Line is longer than 100 characters (found 102).
src/test/java/com/epam/ta/reportportal/core/analyzer/auto/impl/SearchLogServiceImplTest.java|92| Line is longer than 100 characters (found 103).
src/test/java/com/epam/ta/reportportal/ws/converter/converters/UserConverterTest.java|53| Line is longer than 100 characters (found 101).
src/test/java/com/epam/ta/reportportal/ws/converter/converters/OrganizationConverterTest.java|28| Summary javadoc is missing.
src/test/java/com/epam/ta/reportportal/ws/converter/converters/OrganizationConverterTest.java|47| Line is longer than 100 characters (found 112).
src/test/java/com/epam/ta/reportportal/ws/controller/ProjectControllerTest.java|157 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/ws/controller/ProjectControllerTest.java|157 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/ws/controller/ProjectControllerTest.java|321 col 3| Annotation 'Disabled' have incorrect indentation level 2, expected level should be 1.
src/test/java/com/epam/ta/reportportal/ws/controller/ProjectControllerTest.java|361 col 3| Annotation 'Disabled' have incorrect indentation level 2, expected level should be 1.
src/test/java/com/epam/ta/reportportal/ws/controller/OrganizationControllerTest.java|25| Summary javadoc is missing.

String userName = "user";
when(analyzerServiceClient.hasClients()).thenReturn(true);
when(projectRepository.findByName(projectName)).thenReturn(Optional.of(new Project()));
when(projectRepository.findByKey(projectKey)).thenReturn(Optional.of(new Project()));

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'method def' child has incorrect indentation level 16, expected level should be 4.

when(userRepository.findByLogin(userName)).thenReturn(Optional.empty());

ReportPortalException exception = assertThrows(ReportPortalException.class, () -> handler.deleteProjectIndex(projectName, "user"));
ReportPortalException exception = assertThrows(ReportPortalException.class, () -> handler.deleteProjectIndex(projectKey, "user"));

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 100 characters (found 146).

when(userRepository.findByLogin(userName)).thenReturn(Optional.empty());

ReportPortalException exception = assertThrows(ReportPortalException.class, () -> handler.deleteProjectIndex(projectName, "user"));
ReportPortalException exception = assertThrows(ReportPortalException.class, () -> handler.deleteProjectIndex(projectKey, "user"));

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

when(userRepository.findByLogin(userName)).thenReturn(Optional.empty());

ReportPortalException exception = assertThrows(ReportPortalException.class, () -> handler.deleteProjectIndex(projectName, "user"));
ReportPortalException exception = assertThrows(ReportPortalException.class, () -> handler.deleteProjectIndex(projectKey, "user"));

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'method def' child has incorrect indentation level 16, expected level should be 4.

String userName = "user";
Long projectId = 1L;
when(analyzerServiceClient.hasClients()).thenReturn(true);
when(projectRepository.findByName(projectName)).thenReturn(Optional.of(getProjectWithAnalyzerAttributes(projectId, true)));
when(projectRepository.findByKey(TEST_PROJECT_KEY)).thenReturn(Optional.of(getProjectWithAnalyzerAttributes(projectId, true)));

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 100 characters (found 143).

when(userRepository.findByLogin(userName)).thenReturn(Optional.of(new User()));
when(analyzerStatusCache.getAnalyzeStatus(AnalyzerStatusCache.AUTO_ANALYZER_KEY)).thenReturn(Optional.of(CacheBuilder.newBuilder()
.build()));
when(analyzerServiceClient.hasClients()).thenReturn(true);

OperationCompletionRS response = handler.deleteProjectIndex(projectName, "user");
OperationCompletionRS response = handler.deleteProjectIndex(TEST_PROJECT_KEY, "user");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 100 characters (found 102).

when(userRepository.findByLogin(userName)).thenReturn(Optional.of(new User()));
when(analyzerStatusCache.getAnalyzeStatus(AnalyzerStatusCache.AUTO_ANALYZER_KEY)).thenReturn(Optional.of(CacheBuilder.newBuilder()
.build()));
when(analyzerServiceClient.hasClients()).thenReturn(true);

OperationCompletionRS response = handler.deleteProjectIndex(projectName, "user");
OperationCompletionRS response = handler.deleteProjectIndex(TEST_PROJECT_KEY, "user");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

when(userRepository.findByLogin(userName)).thenReturn(Optional.of(new User()));
when(analyzerStatusCache.getAnalyzeStatus(AnalyzerStatusCache.AUTO_ANALYZER_KEY)).thenReturn(Optional.of(CacheBuilder.newBuilder()
.build()));
when(analyzerServiceClient.hasClients()).thenReturn(true);

OperationCompletionRS response = handler.deleteProjectIndex(projectName, "user");
OperationCompletionRS response = handler.deleteProjectIndex(TEST_PROJECT_KEY, "user");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'method def' child has incorrect indentation level 16, expected level should be 4.


verify(logIndexer, times(1)).deleteIndex(projectId);
verify(messageBus, times(1)).publishActivity(any(ProjectIndexEvent.class));

assertEquals(response.getResultMessage(), "Project index with name = '" + projectName + "' is successfully deleted.");
assertEquals(response.getResultMessage(), "Project index with key = '" + TEST_PROJECT_KEY + "' is successfully deleted.");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 100 characters (found 138).


verify(logIndexer, times(1)).deleteIndex(projectId);
verify(messageBus, times(1)).publishActivity(any(ProjectIndexEvent.class));

assertEquals(response.getResultMessage(), "Project index with name = '" + projectName + "' is successfully deleted.");
assertEquals(response.getResultMessage(), "Project index with key = '" + TEST_PROJECT_KEY + "' is successfully deleted.");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

reviewdog

src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|223 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|226| Line is longer than 100 characters (found 135).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|226 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|226 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|242| Line is longer than 100 characters (found 143).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|242 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|242 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|252| Line is longer than 100 characters (found 142).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|252 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|272| Line is longer than 100 characters (found 143).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|272 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|272 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|282| Line is longer than 100 characters (found 142).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|282 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/StartTestItemHandlerImplTest.java|164| Line is longer than 100 characters (found 102).
src/test/java/com/epam/ta/reportportal/core/item/impl/UpdateTestItemHandlerImplTest.java|212| Line is longer than 100 characters (found 101).
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|122 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|122 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|130| Line is longer than 100 characters (found 101).
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|130 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|130 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|139 col 9| 'TEST_PROJECT_KEY' has incorrect indentation level 8, expected level should be 20.
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|158 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|158 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|166| Line is longer than 100 characters (found 101).
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|166 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|166 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|175 col 9| 'TEST_PROJECT_KEY' has incorrect indentation level 8, expected level should be 20.
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|182| Line is longer than 100 characters (found 139).
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|182 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/filter/impl/UpdateUserFilterHandlerTest.java|86| Line is longer than 100 characters (found 101).
src/test/java/com/epam/ta/reportportal/core/filter/impl/UpdateUserFilterHandlerTest.java|114| Line is longer than 100 characters (found 101).
src/test/java/com/epam/ta/reportportal/core/filter/impl/UpdateUserFilterHandlerTest.java|146| Line is longer than 100 characters (found 101).
src/test/java/com/epam/ta/reportportal/core/launch/impl/GetLaunchHandlerImplTest.java|238| Line is longer than 100 characters (found 102).
src/test/java/com/epam/ta/reportportal/core/launch/impl/FinishLaunchHandlerImplTest.java|99| Line is longer than 100 characters (found 101).
src/test/java/com/epam/ta/reportportal/core/launch/impl/FinishLaunchHandlerImplTest.java|121| Line is longer than 100 characters (found 101).
src/test/java/com/epam/ta/reportportal/core/launch/impl/FinishLaunchHandlerImplTest.java|169| Line is longer than 100 characters (found 102).
src/test/java/com/epam/ta/reportportal/core/launch/impl/UpdateLaunchHandlerImplTest.java|161| Line is longer than 100 characters (found 102).
src/test/java/com/epam/ta/reportportal/core/analyzer/auto/impl/SearchLogServiceImplTest.java|92| Line is longer than 100 characters (found 103).
src/test/java/com/epam/ta/reportportal/ws/converter/converters/UserConverterTest.java|53| Line is longer than 100 characters (found 101).
src/test/java/com/epam/ta/reportportal/ws/converter/converters/OrganizationConverterTest.java|28| Summary javadoc is missing.
src/test/java/com/epam/ta/reportportal/ws/converter/converters/OrganizationConverterTest.java|47| Line is longer than 100 characters (found 112).
src/test/java/com/epam/ta/reportportal/ws/controller/ProjectControllerTest.java|157 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/ws/controller/ProjectControllerTest.java|157 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/ws/controller/ProjectControllerTest.java|321 col 3| Annotation 'Disabled' have incorrect indentation level 2, expected level should be 1.
src/test/java/com/epam/ta/reportportal/ws/controller/ProjectControllerTest.java|361 col 3| Annotation 'Disabled' have incorrect indentation level 2, expected level should be 1.
src/test/java/com/epam/ta/reportportal/ws/controller/OrganizationControllerTest.java|25| Summary javadoc is missing.


verify(logIndexer, times(1)).deleteIndex(projectId);
verify(messageBus, times(1)).publishActivity(any(ProjectIndexEvent.class));

assertEquals(response.getResultMessage(), "Project index with name = '" + projectName + "' is successfully deleted.");
assertEquals(response.getResultMessage(), "Project index with key = '" + TEST_PROJECT_KEY + "' is successfully deleted.");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'method def' child has incorrect indentation level 16, expected level should be 4.


}

@Test
void deleteProjectTest() {
String projectName = "test_project";
String projectName = TEST_PROJECT_KEY;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.


}

@Test
void deleteProjectTest() {
String projectName = "test_project";
String projectName = TEST_PROJECT_KEY;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'method def' child has incorrect indentation level 16, expected level should be 4.

@@ -128,13 +129,12 @@ void getUserNamesByIncorrectTerm() {
void getUserNamesNegative() {
ReportPortalException exception = assertThrows(
ReportPortalException.class, () -> handler.getUserNames("",
new ReportPortalUser.ProjectDetails(1L, "superadmin_personal",
ProjectRole.PROJECT_MANAGER
new ReportPortalUser.ProjectDetails(1L, "superadmin_personal", ProjectRole.PROJECT_MANAGER, "project-key"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 100 characters (found 117).

@@ -77,7 +77,7 @@ void TestItemNotFound() {
when(testItemRepository.findById(1L)).thenReturn(Optional.empty());

final ReportPortalException exception = assertThrows(ReportPortalException.class,
() -> handler.getTestItem("1", extractProjectDetails(rpUser, "test_project"), rpUser)
() -> handler.getTestItem("1", extractProjectDetails(rpUser, TEST_PROJECT_KEY), rpUser)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 100 characters (found 119).


ReportPortalException exception = assertThrows(ReportPortalException.class,
() -> handler.getTestItem("1", extractProjectDetails(operator, "test_project"), operator)
() -> handler.getTestItem("1", extractProjectDetails(operator, TEST_PROJECT_KEY), operator)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

@@ -210,8 +210,8 @@
item.setLaunchId(launch.getId());
when(userFilterRepository.findByIdAndProjectId(
1L,
extractProjectDetails(rpUser, "test_project").getProjectId()
)).thenThrow(new ReportPortalException(ErrorType.USER_FILTER_NOT_FOUND_IN_PROJECT, 1L, "test_project"));
extractProjectDetails(rpUser, TEST_PROJECT_KEY).getProjectId()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

extractProjectDetails(rpUser, "test_project").getProjectId()
)).thenThrow(new ReportPortalException(ErrorType.USER_FILTER_NOT_FOUND_IN_PROJECT, 1L, "test_project"));
extractProjectDetails(rpUser, TEST_PROJECT_KEY).getProjectId()
)).thenThrow(new ReportPortalException(ErrorType.USER_FILTER_NOT_FOUND_IN_PROJECT, 1L, TEST_PROJECT_KEY));

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 100 characters (found 122).

extractProjectDetails(rpUser, "test_project").getProjectId()
)).thenThrow(new ReportPortalException(ErrorType.USER_FILTER_NOT_FOUND_IN_PROJECT, 1L, "test_project"));
extractProjectDetails(rpUser, TEST_PROJECT_KEY).getProjectId()
)).thenThrow(new ReportPortalException(ErrorType.USER_FILTER_NOT_FOUND_IN_PROJECT, 1L, TEST_PROJECT_KEY));

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

@@ -220,10 +220,10 @@
.withValue("100")
.withCondition(Condition.EQUALS)
.build())
.build(), PageRequest.of(0, 10), extractProjectDetails(rpUser, "test_project"), rpUser, null, 1L, false, 0);
.build(), PageRequest.of(0, 10), extractProjectDetails(rpUser, TEST_PROJECT_KEY), rpUser, null, 1L, false, 0);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 100 characters (found 142).

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

reviewdog

src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|226 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|242| Line is longer than 100 characters (found 143).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|242 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|242 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|252| Line is longer than 100 characters (found 142).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|252 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|272| Line is longer than 100 characters (found 143).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|272 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|272 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|282| Line is longer than 100 characters (found 142).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|282 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/StartTestItemHandlerImplTest.java|164| Line is longer than 100 characters (found 102).
src/test/java/com/epam/ta/reportportal/core/item/impl/UpdateTestItemHandlerImplTest.java|212| Line is longer than 100 characters (found 101).
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|122 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|122 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|130| Line is longer than 100 characters (found 101).
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|130 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|130 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|139 col 9| 'TEST_PROJECT_KEY' has incorrect indentation level 8, expected level should be 20.
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|158 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|158 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|166| Line is longer than 100 characters (found 101).
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|166 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|166 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|175 col 9| 'TEST_PROJECT_KEY' has incorrect indentation level 8, expected level should be 20.
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|182| Line is longer than 100 characters (found 139).
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|182 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/filter/impl/UpdateUserFilterHandlerTest.java|86| Line is longer than 100 characters (found 101).
src/test/java/com/epam/ta/reportportal/core/filter/impl/UpdateUserFilterHandlerTest.java|114| Line is longer than 100 characters (found 101).
src/test/java/com/epam/ta/reportportal/core/filter/impl/UpdateUserFilterHandlerTest.java|146| Line is longer than 100 characters (found 101).
src/test/java/com/epam/ta/reportportal/core/launch/impl/GetLaunchHandlerImplTest.java|238| Line is longer than 100 characters (found 102).
src/test/java/com/epam/ta/reportportal/core/launch/impl/FinishLaunchHandlerImplTest.java|99| Line is longer than 100 characters (found 101).
src/test/java/com/epam/ta/reportportal/core/launch/impl/FinishLaunchHandlerImplTest.java|121| Line is longer than 100 characters (found 101).
src/test/java/com/epam/ta/reportportal/core/launch/impl/FinishLaunchHandlerImplTest.java|169| Line is longer than 100 characters (found 102).
src/test/java/com/epam/ta/reportportal/core/launch/impl/UpdateLaunchHandlerImplTest.java|161| Line is longer than 100 characters (found 102).
src/test/java/com/epam/ta/reportportal/core/analyzer/auto/impl/SearchLogServiceImplTest.java|92| Line is longer than 100 characters (found 103).
src/test/java/com/epam/ta/reportportal/ws/converter/converters/UserConverterTest.java|53| Line is longer than 100 characters (found 101).
src/test/java/com/epam/ta/reportportal/ws/converter/converters/OrganizationConverterTest.java|28| Summary javadoc is missing.
src/test/java/com/epam/ta/reportportal/ws/converter/converters/OrganizationConverterTest.java|47| Line is longer than 100 characters (found 112).
src/test/java/com/epam/ta/reportportal/ws/controller/ProjectControllerTest.java|157 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/ws/controller/ProjectControllerTest.java|157 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/ws/controller/ProjectControllerTest.java|321 col 3| Annotation 'Disabled' have incorrect indentation level 2, expected level should be 1.
src/test/java/com/epam/ta/reportportal/ws/controller/ProjectControllerTest.java|361 col 3| Annotation 'Disabled' have incorrect indentation level 2, expected level should be 1.
src/test/java/com/epam/ta/reportportal/ws/controller/OrganizationControllerTest.java|25| Summary javadoc is missing.

@@ -128,13 +129,12 @@ void getUserNamesByIncorrectTerm() {
void getUserNamesNegative() {
ReportPortalException exception = assertThrows(
ReportPortalException.class, () -> handler.getUserNames("",
new ReportPortalUser.ProjectDetails(1L, "superadmin_personal",
ProjectRole.PROJECT_MANAGER
new ReportPortalUser.ProjectDetails(1L, "superadmin_personal", ProjectRole.PROJECT_MANAGER, "project-key"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 100 characters (found 117).

@@ -77,7 +77,7 @@ void TestItemNotFound() {
when(testItemRepository.findById(1L)).thenReturn(Optional.empty());

final ReportPortalException exception = assertThrows(ReportPortalException.class,
() -> handler.getTestItem("1", extractProjectDetails(rpUser, "test_project"), rpUser)
() -> handler.getTestItem("1", extractProjectDetails(rpUser, TEST_PROJECT_KEY), rpUser)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 100 characters (found 119).

@@ -77,7 +77,7 @@
when(testItemRepository.findById(1L)).thenReturn(Optional.empty());

final ReportPortalException exception = assertThrows(ReportPortalException.class,
() -> handler.getTestItem("1", extractProjectDetails(rpUser, "test_project"), rpUser)
() -> handler.getTestItem("1", extractProjectDetails(rpUser, TEST_PROJECT_KEY), rpUser)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

@@ -94,10 +94,10 @@
when(testItemService.getEffectiveLaunch(item)).thenReturn(launch);

doThrow(new ReportPortalException("Launch '1' not found. Did you use correct Launch ID?")).when(launchAccessValidator)
.validate(launch.getId(), extractProjectDetails(rpUser, "test_project"), rpUser);
.validate(launch.getId(), extractProjectDetails(rpUser, TEST_PROJECT_KEY), rpUser);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 100 characters (found 115).

@@ -94,10 +94,10 @@
when(testItemService.getEffectiveLaunch(item)).thenReturn(launch);

doThrow(new ReportPortalException("Launch '1' not found. Did you use correct Launch ID?")).when(launchAccessValidator)
.validate(launch.getId(), extractProjectDetails(rpUser, "test_project"), rpUser);
.validate(launch.getId(), extractProjectDetails(rpUser, TEST_PROJECT_KEY), rpUser);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

extractProjectDetails(rpUser, "test_project").getProjectId()
)).thenThrow(new ReportPortalException(ErrorType.USER_FILTER_NOT_FOUND_IN_PROJECT, 1L, "test_project"));
extractProjectDetails(rpUser, TEST_PROJECT_KEY).getProjectId()
)).thenThrow(new ReportPortalException(ErrorType.USER_FILTER_NOT_FOUND_IN_PROJECT, 1L, TEST_PROJECT_KEY));

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

@@ -220,10 +220,10 @@
.withValue("100")
.withCondition(Condition.EQUALS)
.build())
.build(), PageRequest.of(0, 10), extractProjectDetails(rpUser, "test_project"), rpUser, null, 1L, false, 0);
.build(), PageRequest.of(0, 10), extractProjectDetails(rpUser, TEST_PROJECT_KEY), rpUser, null, 1L, false, 0);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 100 characters (found 142).

@@ -220,10 +220,10 @@
.withValue("100")
.withCondition(Condition.EQUALS)
.build())
.build(), PageRequest.of(0, 10), extractProjectDetails(rpUser, "test_project"), rpUser, null, 1L, false, 0);
.build(), PageRequest.of(0, 10), extractProjectDetails(rpUser, TEST_PROJECT_KEY), rpUser, null, 1L, false, 0);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.


final ReportPortalException exception = assertThrows(ReportPortalException.class, executable);
assertEquals("User filter with ID '1' not found on project 'test_project'. Did you use correct User Filter ID?",
assertEquals("User filter with ID '1' not found on project 'o-slug-project-name'. Did you use correct User Filter ID?",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 100 characters (found 135).


final ReportPortalException exception = assertThrows(ReportPortalException.class, executable);
assertEquals("User filter with ID '1' not found on project 'test_project'. Did you use correct User Filter ID?",
assertEquals("User filter with ID '1' not found on project 'o-slug-project-name'. Did you use correct User Filter ID?",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

reviewdog

src/test/java/com/epam/ta/reportportal/core/launch/impl/GetLaunchHandlerImplTest.java|238| Line is longer than 100 characters (found 102).
src/test/java/com/epam/ta/reportportal/core/launch/impl/FinishLaunchHandlerImplTest.java|99| Line is longer than 100 characters (found 101).
src/test/java/com/epam/ta/reportportal/core/launch/impl/FinishLaunchHandlerImplTest.java|121| Line is longer than 100 characters (found 101).
src/test/java/com/epam/ta/reportportal/core/launch/impl/FinishLaunchHandlerImplTest.java|169| Line is longer than 100 characters (found 102).
src/test/java/com/epam/ta/reportportal/core/launch/impl/UpdateLaunchHandlerImplTest.java|161| Line is longer than 100 characters (found 102).
src/test/java/com/epam/ta/reportportal/core/analyzer/auto/impl/SearchLogServiceImplTest.java|92| Line is longer than 100 characters (found 103).
src/test/java/com/epam/ta/reportportal/ws/converter/converters/UserConverterTest.java|53| Line is longer than 100 characters (found 101).
src/test/java/com/epam/ta/reportportal/ws/converter/converters/OrganizationConverterTest.java|28| Summary javadoc is missing.
src/test/java/com/epam/ta/reportportal/ws/converter/converters/OrganizationConverterTest.java|47| Line is longer than 100 characters (found 112).
src/test/java/com/epam/ta/reportportal/ws/controller/ProjectControllerTest.java|157 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/ws/controller/ProjectControllerTest.java|157 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/ws/controller/ProjectControllerTest.java|321 col 3| Annotation 'Disabled' have incorrect indentation level 2, expected level should be 1.
src/test/java/com/epam/ta/reportportal/ws/controller/ProjectControllerTest.java|361 col 3| Annotation 'Disabled' have incorrect indentation level 2, expected level should be 1.
src/test/java/com/epam/ta/reportportal/ws/controller/OrganizationControllerTest.java|25| Summary javadoc is missing.


final ReportPortalException exception = assertThrows(ReportPortalException.class, executable);
assertEquals("User filter with ID '1' not found on project 'test_project'. Did you use correct User Filter ID?",
assertEquals("User filter with ID '1' not found on project 'o-slug-project-name'. Did you use correct User Filter ID?",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'method def' child has incorrect indentation level 16, expected level should be 4.

@@ -239,7 +239,7 @@
item.setLaunchId(launch.getId());
UserFilter filter = new UserFilter();
filter.setTargetClass(ObjectType.TestItem);
when(userFilterRepository.findByIdAndProjectId(1L, extractProjectDetails(rpUser, "test_project").getProjectId())).thenReturn(
when(userFilterRepository.findByIdAndProjectId(1L, extractProjectDetails(rpUser, TEST_PROJECT_KEY).getProjectId())).thenReturn(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 100 characters (found 143).

@@ -239,7 +239,7 @@
item.setLaunchId(launch.getId());
UserFilter filter = new UserFilter();
filter.setTargetClass(ObjectType.TestItem);
when(userFilterRepository.findByIdAndProjectId(1L, extractProjectDetails(rpUser, "test_project").getProjectId())).thenReturn(
when(userFilterRepository.findByIdAndProjectId(1L, extractProjectDetails(rpUser, TEST_PROJECT_KEY).getProjectId())).thenReturn(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

@@ -239,7 +239,7 @@
item.setLaunchId(launch.getId());
UserFilter filter = new UserFilter();
filter.setTargetClass(ObjectType.TestItem);
when(userFilterRepository.findByIdAndProjectId(1L, extractProjectDetails(rpUser, "test_project").getProjectId())).thenReturn(
when(userFilterRepository.findByIdAndProjectId(1L, extractProjectDetails(rpUser, TEST_PROJECT_KEY).getProjectId())).thenReturn(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'method def' child has incorrect indentation level 16, expected level should be 4.

@@ -249,7 +249,7 @@
.withValue("100")
.withCondition(Condition.EQUALS)
.build())
.build(), PageRequest.of(0, 10), extractProjectDetails(rpUser, "test_project"), rpUser, null, 1L, false, 0);
.build(), PageRequest.of(0, 10), extractProjectDetails(rpUser, TEST_PROJECT_KEY), rpUser, null, 1L, false, 0);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 100 characters (found 142).

user
);
verify(integrationRepository, times(1)).deleteAllByProjectIdAndIntegrationTypeId(anyLong(), anyLong());

assertNotNull(operationCompletionRS);
assertEquals(
"All integrations with type ='EMAIL' for project with name ='test_project' have been successfully deleted",
"All integrations with type ='EMAIL' for project with name ='project Name' have been successfully deleted",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 100 characters (found 139).

user
);
verify(integrationRepository, times(1)).deleteAllByProjectIdAndIntegrationTypeId(anyLong(), anyLong());

assertNotNull(operationCompletionRS);
assertEquals(
"All integrations with type ='EMAIL' for project with name ='test_project' have been successfully deleted",
"All integrations with type ='EMAIL' for project with name ='project Name' have been successfully deleted",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

@@ -82,7 +83,7 @@ void updateUserFilterWithTheSameName() {

UpdateUserFilterRQ updateUserFilterRQ = getUpdateRequest(SAME_NAME);

ReportPortalUser.ProjectDetails projectDetails = extractProjectDetails(rpUser, "test_project");
ReportPortalUser.ProjectDetails projectDetails = extractProjectDetails(rpUser, TEST_PROJECT_KEY);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 100 characters (found 101).

@@ -110,7 +111,7 @@

UpdateUserFilterRQ updateUserFilterRQ = getUpdateRequest(ANOTHER_NAME);

ReportPortalUser.ProjectDetails projectDetails = extractProjectDetails(rpUser, "test_project");
ReportPortalUser.ProjectDetails projectDetails = extractProjectDetails(rpUser, TEST_PROJECT_KEY);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 100 characters (found 101).

@@ -142,7 +143,7 @@

UpdateUserFilterRQ updateUserFilterRQ = getUpdateRequest(ANOTHER_NAME);

ReportPortalUser.ProjectDetails projectDetails = extractProjectDetails(rpUser, "test_project");
ReportPortalUser.ProjectDetails projectDetails = extractProjectDetails(rpUser, TEST_PROJECT_KEY);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 100 characters (found 101).

@grabsefx grabsefx changed the base branch from develop to feature/organization-se February 19, 2024 13:31
@grabsefx grabsefx changed the base branch from feature/organization-se to develop February 19, 2024 13:40
@@ -234,7 +235,7 @@ void getOwnersWrongMode() {
getRpUser("user", UserRole.USER, ProjectRole.PROJECT_MANAGER, projectId);

ReportPortalException exception = assertThrows(ReportPortalException.class,
() -> handler.getOwners(extractProjectDetails(user, "test_project"), "qwe", "incorrectMode")
() -> handler.getOwners(extractProjectDetails(user, TEST_PROJECT_KEY), "qwe", "incorrectMode")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 100 characters (found 102).

@@ -95,7 +96,7 @@ void finishLaunch() {
getLaunch(StatusEnum.IN_PROGRESS, LaunchModeEnum.DEFAULT));

FinishLaunchRS response =
handler.finishLaunch("1", finishExecutionRQ, extractProjectDetails(rpUser, "test_project"),
handler.finishLaunch("1", finishExecutionRQ, extractProjectDetails(rpUser, TEST_PROJECT_KEY),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 100 characters (found 101).

@@ -117,14 +118,14 @@
getLaunch(StatusEnum.IN_PROGRESS, LaunchModeEnum.DEFAULT));

final FinishLaunchRS finishLaunchRS =
handler.finishLaunch("1", finishExecutionRQ, extractProjectDetails(rpUser, "test_project"),
handler.finishLaunch("1", finishExecutionRQ, extractProjectDetails(rpUser, TEST_PROJECT_KEY),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 100 characters (found 101).

@@ -165,7 +166,7 @@
getLaunch(StatusEnum.IN_PROGRESS, LaunchModeEnum.DEFAULT));

final List<OperationCompletionRS> response =
stopLaunchHandler.stopLaunch(bulkRq, extractProjectDetails(rpUser, "test_project"), rpUser);
stopLaunchHandler.stopLaunch(bulkRq, extractProjectDetails(rpUser, TEST_PROJECT_KEY), rpUser);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 100 characters (found 102).

@@ -157,7 +158,7 @@ void createClusters() {
ProjectAttributeEnum.UNIQUE_ERROR_ANALYZER_REMOVE_NUMBERS.getDefaultValue());
createClustersRQ.setRemoveNumbers(!defaultRemoveNumbers);

handler.createClusters(createClustersRQ, extractProjectDetails(rpUser, "test_project"), rpUser);
handler.createClusters(createClustersRQ, extractProjectDetails(rpUser, TEST_PROJECT_KEY), rpUser);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 100 characters (found 102).

@@ -140,7 +154,7 @@ void updateProjectPositive() throws Exception {
.contentType(APPLICATION_JSON)
.with(token(oAuthHelper.getSuperadminToken()))).andExpect(status().isOk());

Project project = projectRepository.findByName("test_project").get();
Project project = projectRepository.findByKey("test_project").get();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

@@ -140,7 +154,7 @@
.contentType(APPLICATION_JSON)
.with(token(oAuthHelper.getSuperadminToken()))).andExpect(status().isOk());

Project project = projectRepository.findByName("test_project").get();
Project project = projectRepository.findByKey("test_project").get();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'method def' child has incorrect indentation level 16, expected level should be 4.

@@ -304,6 +318,7 @@
}

@Test
@Disabled("fix null")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] reported by reviewdog 🐶
Annotation 'Disabled' have incorrect indentation level 2, expected level should be 1.

@@ -343,6 +358,7 @@
}

@Test
@Disabled("fix null")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] reported by reviewdog 🐶
Annotation 'Disabled' have incorrect indentation level 2, expected level should be 1.

import com.epam.ta.reportportal.ws.BaseMvcTest;
import org.junit.jupiter.api.Test;

/**

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.javadoc.SummaryJavadocCheck> reported by reviewdog 🐶
Summary javadoc is missing.

@grabsefx grabsefx changed the base branch from develop to feature/orgs February 20, 2024 08:35
@grabsefx grabsefx changed the title Epmrpp 89198 routing refactor EPMRPP-89198 routing refactor Feb 20, 2024
@grabsefx grabsefx merged commit 623d1e0 into feature/orgs Feb 26, 2024
4 checks passed
@grabsefx grabsefx deleted the EPMRPP-89198-routing-refactor branch March 1, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants