Enhancement on scenario name (closes #37 #40)

reportportal · Aug 28, 2020 · 124fa3e · 124fa3e
1 parent 1c4d62a
commit 124fa3e
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 23 deletions.
diff --git a/modules/cucumber-reportportal-formatter.js b/modules/cucumber-reportportal-formatter.js
@@ -162,31 +162,27 @@ const createRPFormatterClass = (config) => {
         [utils.getUri(event.sourceLocation.uri), event.sourceLocation.line].join(':');
       const { featureId } = this.documentsStorage.featureData[event.sourceLocation.uri];
 
-      if (this.contextState.context.lastScenarioDescription !== name) {
-        this.contextState.context.lastScenarioDescription = name;
-        this.contextState.context.outlineRow = 0;
-      } else if (event.attemptNumber < 2) {
-        this.contextState.context.outlineRow += 1;
-        name += ` [${this.contextState.context.outlineRow}]`;
+      if (!(name in this.contextState.context.scenarioNames)) {
+        this.contextState.context.scenarioNames[name] = 1;
+      } else {
+        this.contextState.context.scenarioNames[name] += 1;
+        name += ` [${this.contextState.context.scenarioNames[name]}]`;
       }
 
-      // BeforeScenario
-      if (this.isScenarioBasedStatistics || event.attemptNumber < 2) {
-        this.contextState.context.scenarioId = this.reportportal.startTestItem(
-          {
-            name,
-            startTime: this.reportportal.helpers.now(),
-            type: this.isScenarioBasedStatistics ? 'STEP' : 'TEST',
-            description,
-            codeRef: utils.formatCodeRef(event.sourceLocation.uri, name),
-            parameters: this.contextState.context.scenario.parameters,
-            attributes: itemAttributes,
-            retry: false,
-          },
-          this.contextState.context.launchId,
-          featureId,
-        ).tempId;
-      }
+      this.contextState.context.scenarioId = this.reportportal.startTestItem(
+        {
+          name,
+          startTime: this.reportportal.helpers.now(),
+          type: this.isScenarioBasedStatistics ? 'STEP' : 'TEST',
+          description,
+          codeRef: utils.formatCodeRef(event.sourceLocation.uri, name),
+          parameters: this.contextState.context.scenario.parameters,
+          attributes: itemAttributes,
+          retry: false,
+        },
+        this.contextState.context.launchId,
+        featureId,
+      ).tempId;
     }
 
     onTestStepStarted(event) {

diff --git a/modules/utils.js b/modules/utils.js
@@ -42,6 +42,7 @@ const cleanContext = () => ({
   background: null,
   failedScenarios: {},
   scenariosCount: {},
+  scenarioNames: {},
   lastScenarioDescription: null,
   scenario: null,
   step: null,

diff --git a/tests/cucumber-reportportal-formatter.spec.js b/tests/cucumber-reportportal-formatter.spec.js
@@ -1,3 +1,4 @@
+/* These tests need to be rewritten to reflect the refactoring of the agent. Plans for version 5.0.1. */
 const { createRPFormatterClass } = require('../modules');
 const {
   ContextMock,