Skip to content

Commit

Permalink
Fix PyPy 3.6 handling on macOS
Browse files Browse the repository at this point in the history
  • Loading branch information
domdfcoding committed Jun 12, 2024
1 parent e26743e commit da7eec0
Showing 1 changed file with 9 additions and 2 deletions.
11 changes: 9 additions & 2 deletions repo_helper/files/ci_cd.py
Original file line number Diff line number Diff line change
Expand Up @@ -274,14 +274,18 @@ def make_macos(self) -> PathPlus:
ci_file = self.workflows_dir / f"python_ci_{platform_name.lower()}.yml"

if platform_name in self.templates.globals["platforms"]:
gh_actions_versions = self.get_gh_actions_matrix()
if "pypy-3.6" in gh_actions_versions:
gh_actions_versions.pop("pypy-3.6")

ci_file.write_clean(
self.actions.render(
no_dev_versions=no_dev_versions,
ci_platform=platform_ci_names[platform_name],
ci_name=platform_name,
python_versions=set_gh_actions_versions(self.get_macos_ci_versions()),
dependency_lines=self.get_macos_ci_requirements(),
gh_actions_versions=self.get_gh_actions_matrix(),
gh_actions_versions=gh_actions_versions,
code_file_filter=self._code_file_filter,
)
)
Expand Down Expand Up @@ -464,8 +468,11 @@ def get_macos_ci_versions(self) -> List[str]:

py_versions: List[str] = list(self.templates.globals["python_versions"])

# PyPy 3.6 requires patching on Big Sur
if "pypy36" in py_versions:
py_versions.remove("pypy36") # PyPy 3.6 requires patching on Big Sur
py_versions.remove("pypy36")
if "pypy3.6" in py_versions:
py_versions.remove("pypy3.6")

return py_versions

Expand Down

0 comments on commit da7eec0

Please sign in to comment.