Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include river errors in server side spans #283

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cbrewster
Copy link
Member

Why

This includes errors on the spans generated by the server so we have more error info.

I also changed the names of the spans to match the format that river-python is using.

In order to write a test for this, I had to make it so the tracer is created per-transport rather than having a global one.

What changed

  • De-global the tracer. The transport will construct and own a tracer instance (obtained from the global tracer provider).
  • Add river errors to the server side spans
  • Update the server/client spans to match the format we are using for river-python
    • This may make it harder to look at historical span data, let me know if you think this is a bad idea and I can revert it

Versioning

  • Breaking protocol change
  • Breaking ts/js API change

@cbrewster
Copy link
Member Author

Current dependencies on/for this PR:

This comment was autogenerated by Freephite.

@cbrewster cbrewster requested a review from a team as a code owner January 31, 2025 01:13
@cbrewster cbrewster requested review from Monkatraz and jackyzha0 and removed request for a team January 31, 2025 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant