Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client transport .hardDisconnect #273

Merged
merged 5 commits into from
Oct 14, 2024
Merged

client transport .hardDisconnect #273

merged 5 commits into from
Oct 14, 2024

Conversation

jackyzha0
Copy link
Member

@jackyzha0 jackyzha0 commented Oct 12, 2024 •
edited
Loading

Why + What changed

  • the client had no option to hard disconnect a session
  • session.close only exits the session state machine but the transport never updates its bookkeeping

Versioning

  • Breaking protocol change
  • Breaking ts/js API change

@jackyzha0 jackyzha0 requested a review from a team as a code owner October 12, 2024 10:11
@jackyzha0 jackyzha0 requested review from bradymadden97 and removed request for a team October 12, 2024 10:11
@jackyzha0 jackyzha0 requested a review from Monkatraz October 12, 2024 10:13
@jackyzha0 jackyzha0 changed the title client transport hard disconnect client transport .hardDisconnect Oct 12, 2024
@jackyzha0 jackyzha0 merged commit 1326bc5 into main Oct 14, 2024
4 checks passed
@jackyzha0 jackyzha0 deleted the jackyzha0/hard-disconnect branch October 14, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bradymadden97 bradymadden97 bradymadden97 approved these changes

@Monkatraz Monkatraz Awaiting requested review from Monkatraz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jackyzha0 @bradymadden97