add ability to override codec in transport impls

replit · Nov 30, 2023 · 136a00e · 136a00e
1 parent 239309a
commit 136a00e
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 5 deletions.
diff --git a/transport/impls/stdio.ts b/transport/impls/stdio.ts
@@ -1,8 +1,17 @@
+import { Codec } from '../../codec';
 import { NaiveJsonCodec } from '../../codec/json';
 import { OpaqueTransportMessage, TransportClientId } from '../message';
 import { Transport } from '../types';
 import readline from 'readline';
 
+interface Options {
+  codec: Codec;
+}
+
+const defaultOptions: Options = {
+  codec: NaiveJsonCodec,
+};
+
 /**
  * A transport implementation that uses standard input and output streams.
  * @extends Transport
@@ -27,8 +36,10 @@ export class StdioTransport extends Transport {
     clientId: TransportClientId,
     input: NodeJS.ReadableStream = process.stdin,
     output: NodeJS.WritableStream = process.stdout,
+    providedOptions?: Partial<Options>,
   ) {
-    super(NaiveJsonCodec, clientId);
+    const options = { ...defaultOptions, ...providedOptions };
+    super(options.codec, clientId);
     this.input = input;
     this.output = output;
     const rl = readline.createInterface({

diff --git a/transport/impls/ws.ts b/transport/impls/ws.ts
@@ -7,13 +7,16 @@ import {
   TransportClientId,
 } from '../message';
 import { log } from '../../logging';
+import { type Codec } from '../../codec';
 
 interface Options {
   retryIntervalMs: number;
+  codec: Codec;
 }
 
 const defaultOptions: Options = {
   retryIntervalMs: 250,
+  codec: NaiveJsonCodec,
 };
 
 type WebSocketResult = { ws: WebSocket } | { err: string };
@@ -53,17 +56,18 @@ export class WebSocketTransport extends Transport {
    * Creates a new WebSocketTransport instance.
    * @param wsGetter A function that returns a Promise that resolves to a WebSocket instance.
    * @param clientId The ID of the client using the transport.
-   * @param options An optional object containing configuration options for the transport.
+   * @param providedOptions An optional object containing configuration options for the transport.
    */
   constructor(
     wsGetter: () => Promise<WebSocket>,
     clientId: TransportClientId,
-    options?: Partial<Options>,
+    providedOptions?: Partial<Options>,
   ) {
-    super(NaiveJsonCodec, clientId);
+    const options = { ...defaultOptions, ...providedOptions };
+    super(options.codec, clientId);
     this.destroyed = false;
     this.wsGetter = wsGetter;
-    this.options = { ...defaultOptions, ...options };
+    this.options = options;
     this.sendQueue = [];
     this.tryConnect();
   }