Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore/linting #45

Merged
merged 18 commits into from
Nov 19, 2024
Merged

chore/linting #45

merged 18 commits into from
Nov 19, 2024

Conversation

blast-hardcheese
Copy link
Contributor

  • Added eslint
  • Address concerns
  • Break out runSuite function out of listr2 for debuggability

@blast-hardcheese blast-hardcheese force-pushed the dstewart/chore/linting branch 6 times, most recently from 89228c1 to 491e1e5 Compare November 15, 2024 22:46
@blast-hardcheese blast-hardcheese force-pushed the dstewart/chore/linting branch 5 times, most recently from 57c4f36 to ce0664d Compare November 16, 2024 00:59
@blast-hardcheese
Copy link
Contributor Author

@masad-frost flake: true for tests that only flake on particular languages. Seems as though we're succumbing to bitrot, likely due to npm install instead of npm ci surfacing issues with underlying libraries. Now that the repo is getting in a healthier state, it'll be easier to pin these down and deflake.

masad-frost
masad-frost approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@masad-frost masad-frost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@blast-hardcheese blast-hardcheese merged commit eaa10b4 into main Nov 19, 2024
8 checks passed
@blast-hardcheese blast-hardcheese deleted the dstewart/chore/linting branch November 19, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masad-frost masad-frost masad-frost approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blast-hardcheese @masad-frost