-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #130
Update README.md #130
Conversation
it's more than just auth though. can you elaborate on what is misleading? |
From what I can gather from the documentation, the "web" part only consists of an interface to replit auth and a few helper /wrapper functions. I can't discern any of these features from "application framework". |
Well "vague" is different from "misleading." I think the current wording is sufficient to "draw a user in." While I'm willing to change it, I think that your wording doesn't cover the full scope of |
How about:
It points to the wrappers and helper functions while also mentioning the Auth interface. |
Sounds good. If you update that sentence as you mentioned I'll merge |
Sentence was updated and is ready to merge. |
Will this merge? |
Will it? |
It appears this library stopped getting updates near the time this PR was made, so likely not. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Sorry for the lack of response up until now!
0093130
to
53cd10a
Compare
53cd10a
to
b038e3a
Compare
In the README, I find that this is a little bit misleading.
This change accurately represents the feature as an interface to replit: