Fixes issue where entire settings file wasn't being overwritten, left…

…over data appeared if the new file was shorter
replaysMike · Feb 22, 2022 · 2f7d0b4 · 2f7d0b4
1 parent 652efbb
commit 2f7d0b4
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/Binner/Binner.Web/Controllers/SystemController.cs b/Binner/Binner.Web/Controllers/SystemController.cs
@@ -42,7 +42,7 @@ public SystemController(AutoMapper.IMapper mapper, IServiceContainer container,
         /// </summary>
         /// <returns></returns>
         [HttpPut("settings")]
-        public IActionResult GetSettings(SettingsRequest request)
+        public IActionResult SaveSettings(SettingsRequest request)
         {
             try
             {

diff --git a/Binner/Library/Binner.Common/Services/SettingsService.cs b/Binner/Library/Binner.Common/Services/SettingsService.cs
@@ -39,7 +39,7 @@ public void SaveSettingsAs<T>(T instance, string sectionName, string filename, b
                 throw new BinnerConfigurationException($"There is no section named '{sectionName}' in the configuration file '{filename}'!");
 
             var jsonOutput = JsonConvert.SerializeObject(json, serializerSettings);
-            using var file = File.Open(filename, FileMode.Open, FileAccess.Write, FileShare.Read);
+            using var file = File.Open(filename, FileMode.Create, FileAccess.Write, FileShare.Read);
             var buffer = Encoding.Default.GetBytes(jsonOutput);
             file.Write(buffer, 0, buffer.Length);
             file.Close();