-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup Replay recording on CI #19
Setup Replay recording on CI #19
Conversation
@Andarist is attempting to deploy a commit to the Replay Team on Vercel. To accomplish this, @Andarist needs to request access to the Team. Afterwards, an owner of the Team is required to accept their membership request. If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account. |
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@playwright/[email protected], npm/[email protected] |
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat is an install script?Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts. Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
3af5c96
to
dc5416c
Compare
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
- name: Get Replay Chromium | ||
run: npx replayio update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bvaughn it would be good to have a way to cache replay chromium on CI - we don't make it easy rn to do this. Do you have any opinions on how we could make it happen?
It would be cool if the user wouldn't have to worry about the location that has to be cached. Right now the return value of getRuntimesDirectory
in the new CLI varies based on some env variables etc - so I guess we'd have to expose this logic somehow through the CLI (a new command?).
On top of that, we need a stable cache key - that would be what replayio
returns (but in a machine-readable format): buildId + forkedVersion (or smth like that).
That means the user would have to invoke replayio
twice - it isn't super great but probably OK here.
1580524
to
6888c91
Compare
The most recent CLI failure is related to behavior we mimicked from the legacy CLI (without understanding why) replayio/replay-cli@6d9b8b9#r140402329 |
d3b0cb0
to
c50d296
Compare
It's alive and working :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
REPLAY_API_KEY
secretI tested what I could locally (including uploading the recordings to a sample throwaway workspace).
Note that we can see in the logs things like:
It works regardless of that. Most likely the offending code is here - but fixing this properly requires further investigation.