Add support for SSO login #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
bvaughn
approved these changes
Apr 5, 2024
src/utils/request.ts
Outdated
| @@ -0,0 +1 @@ | |||
| export const getQueryValue = (query: string | string[] | undefined) => (Array.isArray(query) ? query[0] : query); | |||
There was a problem hiding this comment.
nit: Since we've moved this into its own file and we're referencing it in more places now– can we rename this file and method to something more descriptive? "request" is really vague, as is "query value" – something like getValueFromArrayOrString would be clearer I think
src/pages/login.tsx
Outdated
| Sign in with Google | ||
| </Button> | ||
| <Button onClick={onSSOLogin} size="large" variant="outline"> | ||
| Enterprise Users: Sign in with SSO |
There was a problem hiding this comment.
nit
Suggested change
| Enterprise Users: Sign in with SSO | |
| Enterprise Users:<br/>Sign in with SSO |
Also wrap both buttons in:
<div class="flex flex-col gap-2">Before
After
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.