Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinguish network responses from their redirects. #828

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kannanvijayan
Copy link

For #RUN-2343 (https://linear.app/replay/issue/RUN-2343/the-network-monitor-should-show-the-response-url)

Network requests that are redirected currently emit duplicate network request events with the id of the original request.

Disitinguish between these by assigning them a different id.

However, take care to ensure that bookmarks, which are tracked by the underlying "umbrella request id", are properly registered with each network request in the redirect chain.

For #RUN-2343 (https://linear.app/replay/issue/RUN-2343/the-network-monitor-should-show-the-response-url)

Network requests that are redirected currently emit duplicate
network request events with the id of the original request.

Disitinguish between these by assigning them a different id.

However, take care to ensure that bookmarks, which are tracked by the
underlying "umbrella request id", are properly registered with each
network request in the redirect chain.
@kannanvijayan kannanvijayan self-assigned this Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant