Assert access checks + more UseCounter code #1291
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Domiii
commented
Jun 27, 2024
•
Domiii
commented
- paired w/ Assert access checks chromium-v8#260
- also paired w/ https://github.com/replayio/backend/pull/10363 to test our new "test runner changes"
- https://linear.app/replay/issue/TT-366/[atlassian-linkedin]-mismatch-in-pageloadmetricsproxyupdatetiming#comment-c3a7d316
Domiii
force-pushed
the
dominik/tt-1480-assert-more-counter-code
branch
from
5310396 to
59ad771
Compare
…-1480-assert-more-counter-code
…-1480-assert-more-counter-code
…-1480-assert-more-counter-code
…-1480-assert-more-counter-code
…-1480-assert-more-counter-code
Domiii
commented
Jul 9, 2024
| HeapVector<Member<ContextLifecycleObserver>> observers; | ||
| observers_.ForEachObserver([&](ContextLifecycleObserver* observer) { | ||
| observers.push_back(observer); | ||
| observers_.ForEachObserver([](ContextLifecycleObserver* observer) { |
There was a problem hiding this comment.
NOTE: Undid outdated changes. This looks like a very old version of assuring determinism of a HeapObserverSet. I already fixed most of that inside HeapObserverSet itself a long time ago. I added the additional "leaking on Remove" part down below.
|
I closed the wrong thing... |
…-1480-assert-more-counter-code
…-1480-assert-more-counter-code
toshok
approved these changes
Jul 10, 2024
| feature.type(), | ||
| feature.value()); | ||
| REPLAY_ASSERT_IF( | ||
| // [Rebase-Check] This might change with a rebase. |
There was a problem hiding this comment.
what exactly might change? can the answer go in the comment?
| CHECK(iteration_state_ & kAllowingRemoval); | ||
| if (recordreplay::AreEventsDisallowed() && | ||
| recordreplay::IsRecordingOrReplaying("leak-references", "HeapObserverSet")) { | ||
| return; |
There was a problem hiding this comment.
🤔 at "leak-references". this does more than leak/keep-alive: the observer stays around in the list of observers to notify.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.