Issue #437: Cleanup temporary indexes on error (with --only-indexes) #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using --only-indexes pg_repack uses different approach to repack indexes, which is running CREATE INDEX CONCURRENTLY command to create a temporary index and swapping the target index and the temporary index afterwards. That approach didn't use any cleanup callbacks and therefore in case of an error temporary indexes wouldn't be cleaned up. The commit adds the callback repack_cleanup_index.
|
@andreasscherbaum @Melkij I'd merge this PR if no objections. There are no new tests since it will be necessary somehow to throw an error in the middle of repacking of an index. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
--only-indexespg_repackuses different approach to repack indexes, which is running CREATE INDEX CONCURRENTLY command to create a temporary index and swapping the target index and the temporary index afterwards.That approach didn't use any cleanup callbacks and therefore in case of an error temporary indexes wouldn't be cleaned up.
The commit adds the callback
repack_cleanup_index.Issue: #437