-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add apply-count parameter #392
Add apply-count parameter #392
Conversation
alex-richman-onesignal
commented
Apr 12, 2024
•
edited
Loading
edited
- Add a new apply-count command line parameter to allow tuning of the REDO apply_count variable.
- Check on startup that switch_threshold is not greater or equal to apply_count, which would cause REDO to stop after the first apply_log call (fwiw this bug also exists in 1.5.0, since switch_threshold parameter was added but was not checked against the default APPLY_COUNT of 1000).
- Tuning apply_count might be useful for improving REDO performance on tables with small tuples that receive lots of updates.
- Fixes Validate switch_threshold parameter is not greater than or equal to APPLY_COUNT #393
Thanks! No objections from my side. Could you add documentation and tests like here: https://github.com/reorg/pg_repack/pull/347/files#diff-1b3cd3a9c0b8b485f72c559854e6db0705069ce3e995fa25972825d9dcae359a. |
Agree with Artur. A test would be nice to have. Otherwise it's a good addition. |
b818f9f
to
2fbe4be
Compare
Thanks both, added a few tests and a doc line. |
Thanks for the fix. I'm merging the PR. |
Thanks! Do you have a schedule for when the 1.5.1 release will be cut?
We're interested in this and the fix from
#375 but running non-official
releases is a little more challenging for us.
…On Mon, 15 Apr 2024 at 19:43, Artur Zakirov ***@***.***> wrote:
Merged #392 <#392> into master.
—
Reply to this email directly, view it on GitHub
<#392 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AUOKLC5B6BMEX3HRGRZ6J63Y5QNUHAVCNFSM6AAAAABGEK2ZK6VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJSGQ3TKNRRGYYDOMI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
AFAIK we don't have a release schedule. We could make a release after accumulating few more fixes. |