Quote passwords in a connection string

reorg · Feb 28, 2024 · 027811c · 027811c
1 parent 3ecda64
commit 027811c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/bin/pgut/pgut-fe.c b/bin/pgut/pgut-fe.c
@@ -62,7 +62,7 @@ setup_workers(int num_workers)
  		if (username && username[0])
  			appendStringInfo(&buf, "user=%s ", username);
  		if (password && password[0])
- 			appendStringInfo(&buf, "password=%s ", password);
+ 			appendStringInfo(&buf, "password='%s' ", password);
 
  		if (workers.conns == NULL)
  		{
@@ -168,7 +168,7 @@ reconnect(int elevel)
 	if (username && username[0])
 		appendStringInfo(&buf, "user=%s ", username);
 	if (password && password[0])
-		appendStringInfo(&buf, "password=%s ", password);
+		appendStringInfo(&buf, "password='%s' ", password);
 
 	connection = pgut_connect(buf.data, prompt_password, elevel);
 	conn2      = pgut_connect(buf.data, prompt_password, elevel);

diff --git a/bin/pgut/pgut.c b/bin/pgut/pgut.c
@@ -506,7 +506,7 @@ pgut_connect(const char *info, YesNo prompt, int elevel)
 		passwd = prompt_for_password();
 		initStringInfo(&add_pass);
 		appendStringInfoString(&add_pass, info);
-		appendStringInfo(&add_pass, " password=%s ", passwd);
+		appendStringInfo(&add_pass, " password='%s' ", passwd);
 	}
 	else
 	{
@@ -557,7 +557,7 @@ pgut_connect(const char *info, YesNo prompt, int elevel)
 			else
 	 			initStringInfo(&add_pass);
 			appendStringInfoString(&add_pass, info);
-			appendStringInfo(&add_pass, " password=%s ", passwd);
+			appendStringInfo(&add_pass, " password='%s' ", passwd);
 			continue;
 		}