Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(local-dev): add pdm install step #33814

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Conversation

mathisgauthey
Copy link
Contributor

Based on a discussion in #33729, it was missing from the local dev doc.

Changes

I did not find it when trying on my own, I hope it helps future lads in search to contribute to docs.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

Based on a discussion in renovatebot#33729, it was missing from the local dev doc.
@viceice viceice requested a review from HonkingGoose January 24, 2025 08:04
@rarkins rarkins added this pull request to the merge queue Jan 24, 2025
Merged via the queue into renovatebot:main with commit 72a21e0 Jan 24, 2025
39 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 39.127.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@HonkingGoose
Copy link
Collaborator

Should we add the pdm install step to the post-create.sh shell script? This script runs after the GitHub Codespace is created and running.

@mathisgauthey
Copy link
Contributor Author

Should we add the pdm install step to the post-create.sh shell script? This script runs after the GitHub Codespace is created and running.

* [`.devcontainer/post-create.sh` file on `main` branch](https://github.com/renovatebot/renovate/blob/1e9c00b0b902a36d722596ed42c089fb3220d6ba/.devcontainer/post-create.sh)

* [Line which references the `post-create.sh` script in the Devcontainer config file on `main` branch](https://github.com/renovatebot/renovate/blob/1e9c00b0b902a36d722596ed42c089fb3220d6ba/.devcontainer/devcontainer.json#L29)

I guess it could help as well, yes !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants