-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mix): implement lockFileMaintenance #33326
base: main
Are you sure you want to change the base?
feat(mix): implement lockFileMaintenance #33326
Conversation
d93a22e
to
d3b4ba4
Compare
Hello 👋 Is there anything I can do to help move this PR forward? No worries if it's a time issue, I totally get it. All the best! |
Could one of you please explain why we should choose of of the following over the others, from a testing point of view? I searched for a while when I did the PR and couldn't find an answer (this is why I initially left the GlobalConfig.set({ ...adminConfig, binarySource: 'install' }); GlobalConfig.set({
...adminConfig,
binarySource: 'docker',
dockerSidecarImage: 'ghcr.io/containerbase/sidecar',
}); iiuc we can't use |
Well, that's unexpected! The |
Hey there 👋 is this ready for merging or can I do anything else? |
Co-authored-by: Michael Kriese <[email protected]>
Co-authored-by: Michael Kriese <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still open conversation
logger.debug( | ||
'Cannot use lockFileMaintenance in an umbrella project, see https://docs.renovatebot.com/modules/manager/mix/#lockFileMaintenance', | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rarkins should we use a different log level here? i'm unsure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't mind too much about debug logs
Changes
Adds support for the
lockFileMaintenance
option.Refactors the lock file detection to differentiate umbrella projects from classic ones, as this implementation won't work on the former because they share a single
mix.lock
file for multiplemix.exs
files.Cleans up the
getPkgReleases
mocks by only returning the latest version, since these tests aren't about the tool version resolution.Context
Resulting commit: sheerlox-repros/renovate-pr-33326@7ec9c87
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: