Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cache): try/catch package file cache cleanup separately #32074

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Oct 22, 2024

Changes

Moves try/catch for package cache file cleanup to be per-item so that one bad item doesn't stop the full cleanup.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins requested review from viceice and secustor October 22, 2024 05:55
@rarkins rarkins enabled auto-merge October 22, 2024 05:55
@rarkins rarkins added this pull request to the merge queue Oct 23, 2024
Merged via the queue into main with commit 70c03a8 Oct 23, 2024
39 checks passed
@rarkins rarkins deleted the fix/package-file-cache-error-catch branch October 23, 2024 19:49
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 38.130.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants