Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): rebaseWhen = automerging #31527

Merged
merged 58 commits into from
Oct 31, 2024

Conversation

PhilipAbed
Copy link
Collaborator

@PhilipAbed PhilipAbed commented Sep 22, 2024

Changes

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

viceice and others added 30 commits June 5, 2023 16:45
@PhilipAbed PhilipAbed marked this pull request as draft October 28, 2024 12:21
@PhilipAbed PhilipAbed marked this pull request as ready for review October 29, 2024 08:55
@PhilipAbed
Copy link
Collaborator Author

testing e2e again.

@PhilipAbed
Copy link
Collaborator Author

realtime testing for PR text:

case 1:

rebaseWhen='automerging'
automerge=true

results in :
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

case 2:

automerge=true

results in:
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

I believe there's a bug in the PR text here unrelated to my changes
image
i debugged and apparently we are getting auto as default with automerge true.
it should say
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
but it's not.
the Auto is being handled when we are re-using the same branch.
But the text is wrong on the PR,

according to docs:

auto: Renovate will autodetect the best setting. It will use behind-base-branch if configured to automerge or repository has been set to require PRs to be up to date. Otherwise, conflicted will be used instead

case 3:

rebaseWhen='automerging'

results in:
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Never, or you tick the rebase/retry checkbox.

case 4:
default behaviour
results in:
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

should i handle it in this PR or accept this and create a separate PR with a minimal change?

@PhilipAbed PhilipAbed requested a review from rarkins October 29, 2024 10:51
@rarkins
Copy link
Collaborator

rarkins commented Oct 30, 2024

If you've found a bug in existing functionality then please submit a separate fix PR for that first

@PhilipAbed
Copy link
Collaborator Author

ok, the bug was that when creating a new branch we dont determine/transform the value of rebaseWhen
i moved the function above in #32218

now its easier and less changes.

viceice
viceice previously approved these changes Oct 30, 2024
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks simple

@rarkins rarkins added this pull request to the merge queue Oct 31, 2024
Merged via the queue into renovatebot:main with commit ea816f8 Oct 31, 2024
37 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 38.140.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants