Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(manager/nuget): bump VersionPrefix in MSBuild project files #23464

Merged
merged 15 commits into from
Aug 8, 2023

Conversation

dhduvall
Copy link
Contributor

Changes

A project's version isn't always described by a Version property, but sometimes by a VersionPrefix property, out of which the Version is automatically built. This change allows renovate to find and bump that property if it exists.

Context

My .NET library projects all use VersionPrefix, and I would like for renovate to be able to bump their versions when it makes changes.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice viceice changed the title feat: bump VersionPrefix in MSBuild project files feat(manager/nuget): bump VersionPrefix in MSBuild project files Jul 20, 2023
lib/modules/manager/nuget/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/nuget/update.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/nuget/update.ts Outdated Show resolved Hide resolved
lib/modules/manager/nuget/update.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/nuget/extract.ts Outdated Show resolved Hide resolved
@dhduvall
Copy link
Contributor Author

Hey, just checking in to make sure there's nothing you're waiting on me for to move forward, as I think I've addressed all of the issues.

@viceice
Copy link
Member

viceice commented Jul 28, 2023

read our development guides. if You've done that, you would know to use the re-request review function.

@dhduvall dhduvall requested a review from viceice July 28, 2023 17:09
@dhduvall
Copy link
Contributor Author

read our development guides. if You've done that, you would know to use the re-request review function.

Apologies; I hadn't re-read the guide in a bit and I'm not familiar enough to know it by heart. Also, the button is a new enough feature that I haven't used it much. I'll take the time to re-read the guide. Thanks for your patience.

@dhduvall
Copy link
Contributor Author

I've also resolved the conversations as the guide requests, even though I feel a bit uncomfortable doing so. I feel like marking an issue as resolved is up to the person who raised the issue in the first place; I can only guess as to whether it's truly resolved or not.

lib/modules/manager/nuget/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/nuget/update.ts Outdated Show resolved Hide resolved
@dhduvall dhduvall requested a review from viceice July 29, 2023 07:52
lib/modules/manager/nuget/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/nuget/update.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/nuget/update.ts Outdated Show resolved Hide resolved
@dhduvall dhduvall requested a review from viceice July 29, 2023 17:34
@dhduvall dhduvall requested a review from viceice August 3, 2023 02:08
lib/modules/manager/nuget/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/nuget/util.ts Outdated Show resolved Hide resolved
@dhduvall dhduvall requested a review from viceice August 3, 2023 16:35
lib/modules/manager/nuget/update.ts Show resolved Hide resolved
@dhduvall dhduvall requested a review from viceice August 7, 2023 21:30
@viceice viceice added this pull request to the merge queue Aug 8, 2023
Merged via the queue into renovatebot:main with commit 4b55b4e Aug 8, 2023
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 36.36.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@dhduvall dhduvall deleted the feat/versionprefix branch August 8, 2023 07:37
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants