refactor(process/libyear): early return if no releaseTimestamp for …

…current version (#33967)
renovatebot · Jan 31, 2025 · 09b2c10 · 09b2c10
1 parent e82a22d
commit 09b2c10
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 9 deletions.
diff --git a/lib/workers/repository/process/libyear.spec.ts b/lib/workers/repository/process/libyear.spec.ts
@@ -83,11 +83,14 @@ describe('workers/repository/process/libyear', () => {
       };
       calculateLibYears(packageFiles);
       expect(logger.logger.debug).toHaveBeenCalledWith(
-        'No releaseTimestamp for some/image update to 2.0.0',
+        'No currentVersionTimestamp for some/image',
       );
       expect(logger.logger.debug).toHaveBeenCalledWith(
         'No releaseTimestamp for dep1 update to 3.0.0',
       );
+      expect(logger.logger.debug).toHaveBeenCalledWith(
+        'No currentVersionTimestamp for dep3',
+      );
       expect(logger.logger.debug).toHaveBeenCalledWith(
         {
           managerLibYears: {

diff --git a/lib/workers/repository/process/libyear.ts b/lib/workers/repository/process/libyear.ts
@@ -13,6 +13,15 @@ export function calculateLibYears(
     for (const file of files) {
       let fileLibYears = 0;
       for (const dep of file.deps) {
+        if (!dep.currentVersionTimestamp) {
+          logger.debug(`No currentVersionTimestamp for ${dep.depName}`);
+          continue;
+        }
+        // timestamps are in ISO format
+        const currentVersionDate = DateTime.fromISO(
+          dep.currentVersionTimestamp,
+        );
+
         if (dep.updates?.length) {
           for (const update of dep.updates) {
             if (!update.releaseTimestamp) {
@@ -21,14 +30,6 @@ export function calculateLibYears(
               );
               continue;
             }
-            if (!dep.currentVersionTimestamp) {
-              logger.debug(`No currentVersionTimestamp for ${dep.depName}`);
-              continue;
-            }
-            // timestamps are in ISO format
-            const currentVersionDate = DateTime.fromISO(
-              dep.currentVersionTimestamp,
-            );
             const releaseDate = DateTime.fromISO(update.releaseTimestamp);
             const libYears = releaseDate.diff(
               currentVersionDate,