Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure retry interval, maximum number of retries, queue xml params #18

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

mlambley
Copy link

No description provided.

@mlambley
Copy link
Author

Referring to #16 and #17

Also see PR's renatocason/magento2-module-mq-mysql#5 and renatocason/magento2-module-mq-amqp#6

Adding new features for maximum number of retries, and a delay interval before attempting to retry. For example, retry every 300 seconds, 10 times, then fail. Unfortunately due to limitations of amqp, I could not implement them there - they are mysql only features.

Also adding cli params, such as poll interval, to the xml.

I've made an assumption that, if you merge these, you will publish the new version as 2.0.0 because of the breaking changes. Please let me know if you wish to publish as anything other than 2.0.0

Due to the crazy amount of breaking changes I can understand if you don't want these changes, however I will keep them on my github and use them for my purposes. Please also let me know if you have any feedback, or changes to the code before you will accept the PR.

Thank you.

*
* @return bool
*/
public function getQueueRequeue($name);
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your code sniffer wants me to rename this is isQueueRequeue and same for isQueueRunOnce. Please let me know whether you wish for me to make this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant