mypy: Few simple typing fixes #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lslebodn
changed the title
|
Seems like the CI is still failing |
lslebodn
changed the title
I's green now :-) |
added 5 commits
February 4, 2025 16:30
black and idiff log diff which need to be applied. flak8 does nto report diff but can report similar issues
Migrated using: `unittest2pytest -f self_assert -w tests/`
error: Item "None" of "Optional[QueryResponseContainer]" has no attribute "responses" [union-attr] Note: Mypy ignored `self.assertIsNotNone`
tests/test_client.py:43: error: Missing named argument "response" for "HTTPError" [call-arg]
tests/test_client.py:176: error: Unsupported target for indexed assignment ("Collection[Any]") [index]
tests/test_client.py:177: error: Unsupported target for indexed assignment ("Collection[Any]") [index]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and also
Change order of linters
black and idiff log diff which need to be applied.
flak8 does not report diff but can report similar issues.
tests: Use plain assert-statements instead of self.assert* functions
Mypy ignored
self.assertIsNotNoneand still reported failureItem "None" of "Optional[QueryResponseContainer]" has no attribute "responses" [union-attr]Tests were automatically converted using:
unittest2pytest -f self_assert -w tests/