Support new PR view in isMergedPR and isClosedPR
#200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fregante
reviewed
Nov 4, 2024
|
fregante
reviewed
Nov 4, 2024
fregante
reviewed
Nov 4, 2024
| const prStateSelector = [ | ||
| '.State', | ||
| '[class^="StateLabel"]', | ||
| ].join(','); |
There was a problem hiding this comment.
Suggested change
| ].join(','); | |
| ]; |
If it doesn't work, just update select-dom
There was a problem hiding this comment.
I'm referring to dropping .join()
There was a problem hiding this comment.
But it doesn't support string[].
There was a problem hiding this comment.
Ah yeah because we're not using select-dom
fregante
approved these changes
Nov 4, 2024
fregante
changed the title
isMergedPR and isClosedPR
|
Can you also add support for isClosedIssue and any related ones? |
|
I fix below problem in #201 and also support 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.