Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests] Amend typos and <Set /> typings #11894

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Philzen
Copy link
Contributor

@Philzen Philzen commented Jan 10, 2025

Just a handful of test name and typescript amendments – discovered while skimming over https://github.com/redwoodjs/redwood/pull/10464/files

@Philzen Philzen changed the title [test] Amend typos and <Set /> typings [Tests] Amend typos and <Set /> typings Jan 10, 2025
@Philzen
Copy link
Contributor Author

Philzen commented Jan 10, 2025

@Tobbe i'm afraid you're not going to like this (packages/router/src/tests/router.test.tsx):

image

#11739 was still fine – it's also what i would love to see in the next v8 patch release as it fixes what broke during the migration from 7 → 8.

Starting with #11756 the typing all went downhill 🙈
Issue there

  • It was in theory a nice idea of me to use keyof AvailableRoutes for autocompletion, but poorly executed as of course it only worked with my locally generated types in the .redwood folder. So any route name occurences would either have to be @ts-ignored ignored now in the main project or we'd need to find another way to generate those route typings.
  • Then this change (i believe) then broke the nested types

Not sure if this is easily fixable or if we maybe should revert starting from #11756 for the time being and try another day. Just wanted to quickly share this as a heads up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant