Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid explicit constructors invocations, c-style conversions etc, stick to the same implicit conversions used for function calls and returns.
The reason I did not just static_assert for
U
being convertible toT
but actually changed the way it is converted is because semantics ofT(std::forward<U>(v))
may still be different from these of implicit cast inreturn v
. This test would not pass without it:(TODO add the test)