gotohelm: Add MustRegexSplit
#373
Merged
+84
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RafalKorepta
reviewed
Jan 8, 2025
Comment on lines
+253
to
+254
| r := regexp.MustCompile(pattern) | ||
| return r.Split(s, n) |
There was a problem hiding this comment.
On one hand split error is returned to the user, but on the other hand regexp can panic the execution. Could you use regexp.Compile and return an error too?
The same as it is in sprig
https://github.com/Masterminds/sprig/blob/8cb06fe3c8b0f1163c26b0a558669da72ee14656/regex.go#L73-L79
There was a problem hiding this comment.
Nice catch! I can never keep the meaning of Must straight. From gotohelm's perspective, they largely function the same.
Either way, I added support for both!
This commit adds the sprig `mustRegexSplit` function to the `helmette` package.
chrisseto
force-pushed
the
chris/p/gotohelm-mustregexsplit
branch
from
7000bd2 to
d31181a
Compare
RafalKorepta
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the sprig
mustRegexSplitfunction to thehelmettepackage.