-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helm nightly release #345
base: main
Are you sure you want to change the base?
Helm nightly release #345
Conversation
1abe2b1
to
86d064d
Compare
taskfiles/k8s.yml
Outdated
- helm registry login registry-1.docker.io -u {{.DOCKERHUB_USER}} --password {{.DOCKERHUB_TOKEN}} | ||
- helm dep update charts/operator | ||
# To change name of the operator helm chart malformer program is executed | ||
- go run ./nightly-malformer/... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like you could accomplish this by just running helm package --version $TAG_NAME
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The most important change is changing the Chart name just to match the https://hub.docker.com/r/redpandadata/redpanda-operator-nightly docker hub repository. That way we can host helm chart and containers under one repository.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not to be too crotchety but it looks like this could also be handled by a tiny bit of scripting with tar
and yq
. Doing so would be more easily reusable for other charts and not dependent on go loading Chart.yaml
.
taskfiles/k8s.yml
Outdated
- helm dep update charts/operator | ||
# To change name of the operator helm chart malformer program is executed | ||
- go run ./nightly-malformer/... | ||
- helm package charts/operator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: To avoid littering the repo when running this task, it'd be preferable to output the build to either a tempdir or the dist
directory which is git ignored.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree. will adjust.
My personal goal would be to use go program to load chart and the push it to docker hub. I'm using helm cli just for the quick turnaround.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we might be able to fix that with some help from dev prod? If we can update the k8s-builders to use the containerd image store by default multi platform builds will "just work"1.
Footnotes
de6a54f
to
8af6cca
Compare
8af6cca
to
5f19af1
Compare
taskfiles/k8s.yml
Outdated
- helm registry login registry-1.docker.io -u {{.DOCKERHUB_USER}} --password {{.DOCKERHUB_TOKEN}} | ||
- helm dep update charts/operator | ||
# To change name of the operator helm chart malformer program is executed | ||
- go run ./nightly-malformer/... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not to be too crotchety but it looks like this could also be handled by a tiny bit of scripting with tar
and yq
. Doing so would be more easily reusable for other charts and not dependent on go loading Chart.yaml
.
0044739
to
cd5be15
Compare
taskfiles/k8s.yml
Outdated
- mkdir helm-operator-release | ||
- defer 'rm -r helm-operator-release' | ||
- yq -i '.name = "redpanda-operator-nightly"' charts/operator/Chart.yaml | ||
- helm package charts/operator --version "{{.TAG_NAME}}-helm-chart" --destination helm-operator-release --dependency-update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah right, I forgot this had to be renamed as well. Could you include an example command of how one might use the nightly build?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if I should copy what is in official helm documentation how to use helm repository where chart's are stored?
I can make a comment to reference official docker hub announcement https://www.docker.com/blog/announcing-docker-hub-oci-artifacts-support/
I could point to our artifact https://hub.docker.com/layers/redpandadata/redpanda-operator-nightly/v0.0.0-20250104git4a5a076-helm-chart/images/sha256-ffaea8752b6bd00a26589a168830a87d498106e470f11af0f08267bc13fbd078
where you can find all commands
What would you prefer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where you can find all commands
Oh that's awesome! Yeah a link out to that page would be perfect.
I think it'd be good to include a note (or link to that forum post you had found) about why the tagging is suffixed with -helm-chart
.
dda810e
to
621bed9
Compare
621bed9
to
cda3d10
Compare
cda3d10
to
38e78b5
Compare
On top of:
Successful run https://buildkite.com/redpanda/redpanda-operator/builds/3937
The artifacts created from above pipeline:
Buildkite scheduled build settings
K8S-440