Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update decommission test for latest changes #19

Merged
merged 3 commits into from
Nov 21, 2023

Conversation

alejandroEsc
Copy link
Contributor

@alejandroEsc alejandroEsc commented Nov 20, 2023

Latest changes to the helm chart currently roll pods in an unexpected manner. I would like to ensure that current helm changes are still passing today.

@alejandroEsc alejandroEsc self-assigned this Nov 20, 2023
@RafalKorepta
Copy link
Contributor

Latest changes roll pods in an unexpected manner

What changes? I see you are updating helm chart, so in 5.3.2 we had different order?

@alejandroEsc
Copy link
Contributor Author

Latest changes roll pods in an unexpected manner

What changes? I see you are updating helm chart, so in 5.3.2 we had different order?

Latest helm changes. Yes that is what i mean.

Copy link
Contributor

@RafalKorepta RafalKorepta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good, but I don't understand description of the problem in cover letter.

@alejandroEsc alejandroEsc merged commit d03a1bb into main Nov 21, 2023
7 checks passed
@alejandroEsc alejandroEsc deleted the ae/update/decomm branch November 21, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants