Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PR buildkite execution #17

Merged
merged 8 commits into from
Nov 20, 2023
Merged

Fix PR buildkite execution #17

merged 8 commits into from
Nov 20, 2023

Conversation

RafalKorepta
Copy link
Contributor

In this PR:

  • unit tests will be always performed - condition removed
  • golangci-lint is bumped to the latest 1.55.2 version
  • apply lint suggestion in each individual commit

@RafalKorepta RafalKorepta force-pushed the rk/fix-PR-buildkite-execution branch from 0476f76 to 3133680 Compare November 20, 2023 16:37
alejandroEsc
alejandroEsc approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@alejandroEsc alejandroEsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, glad this will run in general now.

@RafalKorepta RafalKorepta merged commit b770bbd into main Nov 20, 2023
7 checks passed
@alejandroEsc alejandroEsc deleted the rk/fix-PR-buildkite-execution branch November 20, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alejandroEsc alejandroEsc alejandroEsc approved these changes

@nk-87 nk-87 Awaiting requested review from nk-87

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RafalKorepta @alejandroEsc