Gotohelm "secrets.yaml", if genericity were supported. #1372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes a fix to a long-standing bug: the curl arguments for an admin listener that doesn't require a client cert named the wrong file. This replicates blank lines in generated shell scripts with high fidelity to the helm originals, but that can be relaxed once the conversion is complete.
This includes a fix to a long-standing bug: the curl arguments for an admin listener that doesn't require a client cert named the wrong file. This replicates blank lines in generated shell scripts with high fidelity to the helm originals, but that can be relaxed once the conversion is complete.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a couple of approaches we might take here.
One is a monomorphisation pass over the input to gotohelm (this takes it a long way from being a mere AST walker however), but I think it's doable.
The second could be to push down the genericity of the KafkaExternal and HTTPExternal structures. These are identical with the exception of their AuthenticationMethod field (in both cases a pointer to something structurally identical to string; schema annotations vary).