Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC-1011 Add Keycloak and AzureAD to AuthZ topic for Console #975

Merged
merged 3 commits into from
Feb 6, 2025

Conversation

JakeSCahill
Copy link
Contributor

@JakeSCahill JakeSCahill commented Feb 4, 2025

Description

Resolves https://github.com/redpanda-data/documentation-private/issues/
Review deadline:

Page previews

https://deploy-preview-975--redpanda-docs-preview.netlify.app/current/console/config/security/authorization/#subjects

Checks

  • New feature
  • Content gap
  • Support Follow-up
  • Small fix (typos, links, copyedits, etc)

@JakeSCahill JakeSCahill requested a review from a team as a code owner February 4, 2025 15:17
@JakeSCahill JakeSCahill requested a review from weeco February 4, 2025 15:17
Copy link

netlify bot commented Feb 4, 2025

Deploy Preview for redpanda-docs-preview ready!

Name Link
🔨 Latest commit a0bbfb6
🔍 Latest deploy log https://app.netlify.com/sites/redpanda-docs-preview/deploys/67a4abf3aad42b0008268959
😎 Deploy Preview https://deploy-preview-975--redpanda-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

| `user`
| user
| AzureAD
| User's OID (or email address if using a custom identifying claim)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we write OID out in full first time, assuming this is the object ID?

| Google
| Google Group Name (which is an email address)

| `user`
| user
| GitHub
| Login handle / GitHub username
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we use spacing before and after forward slash but not on line 162

Copy link
Contributor

@asimms41 asimms41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just some suggestions but no blockers.

@JakeSCahill JakeSCahill merged commit 3a13c02 into main Feb 6, 2025
6 of 7 checks passed
@JakeSCahill JakeSCahill deleted the DOC-1011 branch February 6, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants