Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial commit with boilerplate #1

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Initial commit with boilerplate #1

merged 1 commit into from
Feb 29, 2024

Conversation

weeco
Copy link
Contributor

@weeco weeco commented Feb 26, 2024

Just the initial boilerplate setup with a first package that serves some utility functions for working with connect.Errors as well as some boilerplate setup for the gRPC gateway.

This is how we use it in Console, please check if something would be missing for internal services.

@weeco weeco requested review from bojand, birdayz and sago2k8 February 26, 2024 23:47
@weeco weeco force-pushed the setup-boilerplate branch from be5a274 to d79bf48 Compare February 27, 2024 15:04
@weeco weeco force-pushed the setup-boilerplate branch from 7d4874d to 84404a5 Compare February 27, 2024 16:21
repo-token: ${{ secrets.GITHUB_TOKEN }}

- name: fmt
run: task fmt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we run lint and test?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no test command yet, but I did not use the lint task on purpose because I wanted to see the annotated output of the lint action instead. We wouldn't have that by just running the task command.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, these annotations are great.

@weeco weeco requested review from sago2k8 and bojand February 27, 2024 21:15
@weeco weeco merged commit 0837495 into main Feb 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants