Skip to content

Commit

Permalink
Merge pull request #36 from redpanda-data/ts/simplify-secret-exists-f…
Browse files Browse the repository at this point in the history
…or-aws

Simplify checking secret existence for AWS
  • Loading branch information
tomasz-sadura authored Nov 12, 2024
2 parents 9ddb03b + a5bf4a6 commit 1ea80df
Showing 1 changed file with 3 additions and 20 deletions.
23 changes: 3 additions & 20 deletions secrets/aws.go
Original file line number Diff line number Diff line change
Expand Up @@ -44,25 +44,8 @@ func (a *awsSecretsManager) GetSecretValue(ctx context.Context, key string) (str
}

func (a *awsSecretsManager) CheckSecretExists(ctx context.Context, key string) bool {
secrets, err := a.client.ListSecrets(ctx, &secretsmanager.ListSecretsInput{
Filters: []types.Filter{
{
// this is a prefix check
Key: types.FilterNameStringTypeName,
Values: []string{key},
},
},
_, err := a.client.DescribeSecret(ctx, &secretsmanager.DescribeSecretInput{
SecretId: &key,
})
if err != nil {
return false
}

// we need to make sure a secret with this specific key exists
for _, secret := range secrets.SecretList {
if *secret.Name == key {
return true
}
}

return false
return err == nil
}

0 comments on commit 1ea80df

Please sign in to comment.