Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hide HLS env var to match documentation #86

Merged
merged 1 commit into from
May 29, 2024
Merged

Update hide HLS env var to match documentation #86

merged 1 commit into from
May 29, 2024

Conversation

EMarshal
Copy link
Contributor

@EMarshal EMarshal commented Apr 7, 2024

The documentation/examples here don't match the variable that gets parsed, leading to the variable not taking effect if the documentation/examples are followed.

I've updated the expected variable name in code, as "HIDE_HLS" is only referenced a single time, while every other reference is to "HIDE_HLS_NOTIFICATION", but this is a breaking change; anyone who had REDLIB_DEFAULT_HIDE_HLS=on will see their setting stop working.

If you'd prefer, I can amend the PR/fix to instead update the documentation to match the code, which would make the fix non-breaking, at the expense of consistency of variable names.

@sigaloid sigaloid merged commit e13d9b7 into redlib-org:main May 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants