Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace askama with rinja #276

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Conversation

GuillaumeGomez
Copy link
Contributor

Recently, me and another askama maintainer forked the project into rinja. For more details about the why, I wrote a blog post here. But in short: rinja is ahead of askama now in a lot of areas so I think going forward, your project will benefit more from it.

If you're not interested about this switch, don't hesitate to close the PR.

If you want more information about rinja, don't hesitate to ask!

@sigaloid
Copy link
Member

sigaloid commented Oct 1, 2024

Thank you for the detailed blog post! The improvements seem compelling, so I'm happy to switch. You can ignore the failing test, but the fmt failing seems accurate - do you mind running cargo fmt to reorder the inputs in your branch, or would you prefer I do it in your branch?

@GuillaumeGomez
Copy link
Contributor Author

Glad to hear it! I'll run cargo fmt. Didn't think about it. ^^'

@GuillaumeGomez
Copy link
Contributor Author

Updated!

@sigaloid
Copy link
Member

sigaloid commented Oct 2, 2024

Awesome, thanks!

@sigaloid sigaloid merged commit 1838fda into redlib-org:main Oct 2, 2024
2 of 3 checks passed
@GuillaumeGomez GuillaumeGomez deleted the rinja branch October 3, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants