Less buggy solution to solving the floating footer problem #18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that my previous fix for this had a problem where the footer would end up on the wrong spot in very short posts that had no comments, sorry about that!
This is a much simpler fix to the problem that also avoids running into that issue.
After another look I realized that the problem revolves around what classes the body has. Only the fixed_navbar class had
position: relative;
and therefore when the body lost that from turning "Keep navbar fixed" off, the footer was no longer relative to the body. Hence why it would show up at the bottom of the initial viewport and be fixed there.This fix just restores the old CSS file and gives the card class the same properties as the fixed_navbar class besides it's top padding in order to make sure both are in line with each other and combat that problem.