Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Redis 6.2] Add EXAT/PXAT options to SET #1028

Merged
merged 1 commit into from
Sep 13, 2021
Merged

[Redis 6.2] Add EXAT/PXAT options to SET #1028

merged 1 commit into from
Sep 13, 2021

Conversation

magni-
Copy link
Contributor

@magni- magni- commented Sep 13, 2021 •
edited
Loading

First PR here 👋🏼 For tests, I took inspiration from #1024 as well as the existing tests for SET using EX / PX.
Documentation is copy-pasted from https://redis.io/commands/set#options

References: #978

byroot
byroot approved these changes Sep 13, 2021
View reviewed changes
Copy link
Collaborator

@byroot byroot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I'll merge on green CI.

@byroot byroot merged commit c97360b into redis:master Sep 13, 2021
@magni- magni- deleted the pp/set-exat branch September 13, 2021 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byroot byroot byroot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@magni- @byroot