-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Async clusters: Support creating locks inside async functions #2471
Conversation
This allows creating the client at the module level or before the event loop has been initialized.
ca50834
to
1b32bbb
Compare
Codecov ReportBase: 92.22% // Head: 92.21% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2471 +/- ##
==========================================
- Coverage 92.22% 92.21% -0.01%
==========================================
Files 113 113
Lines 29321 29325 +4
==========================================
+ Hits 27042 27043 +1
- Misses 2279 2282 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@utkarshgupta137 We're still waiting on #2407 and given your fix.. I'm pretty good with this getting into 4.4 as that merge. Let's give a bit longer (end of week maybe) for your PR in arq, and then we can merge it down + decide. Does that work for you? I'd really like to not have multiple releases :D |
Sure, it would work for me. But I don't think it is reasonable to wait for a third-party package to fix what is essentially a misuse (undefined behaviour) on their end. For all we know, there could be many other packages out there misusing some functionality of this package... |
@utkarshgupta137 I randomly head out to the internet and contribute version caps for reasons like this. Part of a general goal of not breaking the community means I was happy to delay in this case, especially with the backport to 4.3.5. Thanks again for the fix in arq - this goes into 4.4x. |
Pull Request check-list
$ tox
pass with this change (including linting)?Description of change
This allows creating the client at the module level or before the event loop has been initialized.
Ref: encode/starlette#1315 (comment)